Removes redis dependency. #14

Merged
merged 1 commit into from Oct 23, 2012

Conversation

Projects
None yet
2 participants
Contributor

cpsubrian commented Oct 23, 2012

This updates RedisStore to only require('redis') if it needs to. This is the same way socket.io does things so it seems reasonably standard.

Owner

tj commented Oct 23, 2012

hmm needs a rebase i guess since i merged your other one

Contributor

cpsubrian commented Oct 23, 2012

Rebased and force-pushed. Should we think about upping the version?

Owner

tj commented Oct 23, 2012

nah always best to leave versioning to the author

tj added a commit that referenced this pull request Oct 23, 2012

Merge pull request #14 from cpsubrian/redis
Removes redis dependency.

@tj tj merged commit 221d8b2 into tj:master Oct 23, 2012

Contributor

cpsubrian commented Oct 23, 2012

Sorry, meant the redis version. But now that its not a dep the only reason it would matter is if the tests pass for 0.8.1 but would fail for 0.9.x.

Contributor

cpsubrian commented Oct 23, 2012

What am I smoking? redis is 0.8.1 right now ... too many modules in my head :)

Owner

tj commented Oct 23, 2012

ah :D haaha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment