Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Removes redis dependency. #14

Merged
merged 1 commit into from

2 participants

@cpsubrian

This updates RedisStore to only require('redis') if it needs to. This is the same way socket.io does things so it seems reasonably standard.

@tj
Owner
tj commented

hmm needs a rebase i guess since i merged your other one

@cpsubrian

Rebased and force-pushed. Should we think about upping the version?

@tj
Owner
tj commented

nah always best to leave versioning to the author

@tj tj merged commit 221d8b2 into tj:master
@cpsubrian

Sorry, meant the redis version. But now that its not a dep the only reason it would matter is if the tests pass for 0.8.1 but would fail for 0.9.x.

@cpsubrian

What am I smoking? redis is 0.8.1 right now ... too many modules in my head :)

@tj
Owner
tj commented

ah :D haaha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 23, 2012
  1. @cpsubrian

    Removes redis dependency.

    cpsubrian authored
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 5 deletions.
  1. +2 −3 lib/stores/RedisStore.js
  2. +2 −2 package.json
View
5 lib/stores/RedisStore.js
@@ -4,8 +4,7 @@
*/
var EventEmitter = require('events').EventEmitter
- , debug = require('debug')('jog:redis')
- , redis = require('redis');
+ , debug = require('debug')('jog:redis');
/**
* Expose `RedisStore`.
@@ -22,7 +21,7 @@ module.exports = RedisStore;
*/
function RedisStore(client, key) {
- this.db = client || redis.createClient();
+ this.db = client || require('redis').createClient();
this.key = key || 'jog';
this.rangeSize = 300;
}
View
4 package.json
@@ -8,13 +8,13 @@
, "bin": { "jog": "./bin/jog" }
, "dependencies": {
"debug": "*",
- "redis": "0.8.1",
"commander": "0.5.2",
"ms": "0.1.0"
}
, "devDependencies": {
"mocha": "*",
- "should": "*"
+ "should": "*",
+ "redis": "0.8.1"
}
, "main": "index"
, "engines": { "node": "*" }
Something went wrong with that request. Please try again.