Fix for running on ubuntu 10.10 + #3

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@jgallen23

here's the reference on why it's not working: ddollar/foreman#26 (comment)

Tested on ubuntu 12.04 and osx 10.7.3

Fixes #2

@tj
Owner
tj commented Apr 28, 2012

ill have to test it out, assuming bash is probably going to break on more systems than /bin/sh which is usually linked to bash anyway but we'll see

@guybrush guybrush referenced this pull request Sep 19, 2012
Merged

fix start #7

@guybrush

this should be merged :p

@guybrush

oh, actually i use execl("/bin/bash", "sh", "-c", cmd, 0);, not sure if it makes any difference?

@tj
Owner
tj commented Sep 19, 2012

two shells? haha that's a bit inceptiony

@guybrush

lol :p

@tj
Owner
tj commented Nov 10, 2012

closing. dont know wtf dash is doing, we just replaced /bin/sh with bash instead and all is happy. we could try signalling the pgid, cant remember if we tried that but whatever we can revisit that if necessary

@tj tj closed this Nov 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment