Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Use rsync instead of cp when activating versions #104

Closed
wants to merge 1 commit into from

3 participants

@jasonmorganson

The cp command is not capable of handling symlinks properly. The rync command treats symlinked directories on receiver as regular directories.

This is a way of working around the issues cp reports when it encounters symlinks as reported in Issue #100.

@jasonmorganson jasonmorganson Use rsync instead of cp when activating versions
The cp command is not capable of handling symlinks properly. The rync command treats symlinked directories on receiver as regular directories.
22d2728
@benatkin
Collaborator

I like rsync but I'd rather not make it a dependency.

@benatkin
Collaborator

I'm debating whether to make it detect whether it needs to use rsync and use rsync, or to run cp more than once.

@tjwebb
Collaborator

I also like rsync, but I'm worried about it causing many of the issues that n's curl dependency has caused.

@tjwebb tjwebb closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 10, 2013
  1. @jasonmorganson

    Use rsync instead of cp when activating versions

    jasonmorganson authored
    The cp command is not capable of handling symlinks properly. The rync command treats symlinked directories on receiver as regular directories.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  bin/n
View
2  bin/n
@@ -242,7 +242,7 @@ activate() {
local dir=$VERSIONS_DIR/$version
check_current_version
echo $active > $VERSIONS_DIR/.prev
- cp -fr $dir/* $N_PREFIX
+ rsync -K -a $dir/* $N_PREFIX
}
#
Something went wrong with that request. Please try again.