Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

get tests working reliably #1

Closed
aheckmann opened this Issue · 8 comments

2 participants

@aheckmann
Collaborator

don't work on unbuntu

@tj
Owner
tj commented

at all? shit lol should work at least 1/5 times haha :D socket writes must behave slightly different. not sure what would be best, we kinda have to implement the protocol and create a client to frame the chunks properly, but at the same time we want to test invalid protocol stuff too. we could use node_redis for the valid stuff

@aheckmann
Collaborator

yeah, nothing passes. I tried it a ton of times (~15 or so).

@tj
Owner
tj commented

haha damn

@aheckmann
Collaborator
... hvals 2ms
... hmset 

  expected: 
  +OK\r\n
  +OK\r\n
  $2\r\n
  tj\r\n
  $4\r\n
  tobi\r\n

  got: 
  +OK\r\n
@tj
Owner
tj commented

hmm, yeah tough to frame broken protocol tests, if it were not for that we could easily do it. the broken tests might have to be done differently

@aheckmann
Collaborator

i'm not positive yet but .once may be cutting off the rest of the response?

@tj
Owner
tj commented

the packet sizes must just be different, tests are working 100% consistently for me now, but the data event in the runner is definitely prone to a race-condition. think i have a plan actually

@aheckmann
Collaborator

get tests working reliably

now works on ubuntu. closed by d2b7aa9

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.