Inline-block support #102

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
5 participants

inline-block support
ie7
firefox 2 (-moz-inline-stack)
inline-block prefix for older browser version

iulian meghea Added inline-block support for
	ie7
	firefox 2 (-moz-inline-stack)
	inline-block prefix for older browser version
b7826cd
Owner

tj commented May 29, 2012

LGTM - firefox 2 though? that's a bit old no?

Hmm,

I quess I can remove that for firefox 2.
And maybe vendor prefixes for inline-block are also too much too.

Owner

tj commented May 29, 2012

I've never had problems with them, but I use the latest of safari/ff/chrome

iulian meghea Added inline-block support for IE
Removed inline-block fix for IE in reset.styl (generated duplicate)
9b0ad07

megheaiulian reopened this May 30, 2012

sgtpep commented Jun 10, 2012

Just FYI guys. Support table for inline-block: http://caniuse.com/#search=inline-block

puzrin commented Aug 9, 2012

@visionmedia we use the same shim for IE6-7 and it greately helps (also dropped FF2 hack):

// inline-block shim for IE7
//
display(type)
  if inline-block == type
    display: inline-block
    *display: inline
    *zoom: 1
  else
    display: type

in real project

Please, add to nib, that's a well-known solution. Thanks.

Owner

tj commented Aug 9, 2012

PR :D

puzrin commented Aug 9, 2012

Yeah, PR of source code, LOL.

PS. I've found original article: http://blog.mozilla.org/webdev/2009/02/20/cross-browser-inline-block/ . Look at the date. Suggested difference:

  • no FF2 support
  • asterisk before zoom - isolates IE8+ and mobiles.
Owner

tj commented Aug 9, 2012

no i mean pull-request :p

3rd-Eden commented Aug 9, 2012

This is only needed if the element that you apply inline-block on isn't a inline element as inline-block works perfectly fine on regular inline elements such as strong or span. This is probably going to add a lot of pointless CSS for those cases.

puzrin commented Aug 9, 2012

IMHO, that's mostly used with li, to avoid side-effects of float:left. I think, possible overhead will not be noticeable in zipped css. And practical value of that shim is good enougth.

Owner

tj commented Aug 9, 2012

yeah everyone gzips anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment