Corrections for IE10 flexbox #188

Merged
merged 10 commits into from Jul 22, 2013

Projects

None yet

8 participants

@juriejan
Contributor
juriejan commented Jun 6, 2013

Corrected 'flebox' utilities to play nice in IE10 using the following guides:

http://msdn.microsoft.com/en-us/library/ie/hh772069(v=vs.85).aspx
http://zomigi.com/blog/flexbox-syntax-for-ie-10/

As briefly discussed in tj/nib#174

@old9
Contributor
old9 commented Jun 25, 2013

+1 for this

@slang800
Collaborator

needs to be rebased first, other than that, it looks great. thanks @juriejan

@Pickachu

👍

@luccamordente

👍

@renehamburger
Contributor

Added one more fix (IE-10 equivalent of align-self) and rebased everything on your current master branch.

@slang800 slang800 merged commit 3988814 into tj:master Jul 22, 2013

1 check passed

default The Travis CI build passed
Details
@slang800
Collaborator

thankyou @juriejan and @renehamburger

@Pickachu

Thanks for the good job! @juriejan @renehamburger

@optikfluffel
Contributor

👍

@old9
Contributor
old9 commented Aug 7, 2013

👍 for a npm update

@slang800
Collaborator
slang800 commented Aug 7, 2013

yeah, we really do need to bump the version... do you think this should be a major version bump? ... cause the gradients thing and this were both pretty big changes.

@kizu
Contributor
kizu commented Aug 7, 2013

Yes, I'd say this should be a major version bump here.

@slang800
Collaborator

done! ... bumped to 1.0.0

@old9 old9 commented on the diff Aug 23, 2013
lib/nib/flex.styl
@@ -10,8 +10,11 @@ flex-version ?= box flex
//
display(type, args...)
if flex == type || inline-flex == type
- display: vendor-value(box args, only: moz ms webkit) if box in flex-version
- display: vendor-value(arguments, only: webkit official) if flex in flex-version // overwrites old webkit
+ if box in flex-version
+ display: -ms-flexbox args
@old9
old9 Aug 23, 2013 Contributor

seems that we are lacking the -ms-inline-flexbox here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment