bunch of stuff #192

Merged
merged 15 commits into from Jul 31, 2013

Conversation

Projects
None yet
3 participants
Collaborator

slang800 commented Jun 15, 2013

see the commit messages for what's going on here

this closes:

and sets up support for Travis CI, which we need to enable. Travis CI is enabled

Collaborator

slang800 commented Jun 16, 2013

I've rebased commits from #94 but there is still one failing test that i'm not sure how to fix. @kizu, could you look into this? I think something in flex.styl is conflicting with the new vendor function and causing it to carry over properties from the previous rule... very odd stuff.

Contributor

kizu commented Jun 18, 2013

@slang800 I saw that those tests were added here, by @kpdecker: https://github.com/slang800/nib/commit/5c2f1d1c69c013970235950fcd6b3cf35b0d7c87, and there were a lot of commits there, so maybe he could tell what should go there? Is it looks from the tests, there should be the fix for the auto value, so it should be translated to 1 for old syntax, and some other such minor stuff.

Also, as I know, old syntax was supported only with -webkit- and -moz- prefixes, so this place could be optimized a bit more, by removing the never used prefixes from the old syntax flexbox properties.

I fear I won't have time to fix this issues by myself, but thanks anyway for getting into this issue, hope everything would resolve nicely!

This was referenced Jun 19, 2013

+ list-style-image: -moz-linear-gradient(50deg, #f00, #0f0);
+ list-style-image: -ms-linear-gradient(50deg, #f00, #0f0);
+ list-style-image: -o-linear-gradient(50deg, #f00, #0f0);
+ list-style-image: linear-gradient(40deg, #f00, #0f0);
@slang800

slang800 Jul 31, 2013

Collaborator

@kizu, the official version of a linear gradient isn't supposed to have a different degree than all of the vendor-prefixed ones, right? ... So the others should be 40deg, rather than 50deg?

@kizu

kizu Jul 31, 2013

Contributor

Nope, that's exactly how it should be — when the gradients were unprefixed, the w3c changed the syntax, see this article, for example:

0deg is a gradient line pointing to the top. Angles increase in a clockwise direction. Old angles can be converted to new angles using the formula new = abs(old−450) mod 360

@slang800

slang800 Jul 31, 2013

Collaborator

ah! thanks for the explanation, that makes much more sense!

slang800 added a commit that referenced this pull request Jul 31, 2013

Merge pull request #209 from slang800/gradients1
small fixes for gradients (another chunk of #192)
Collaborator

slang800 commented Jul 31, 2013

ok, all 15 tests pass now!

slang800 added a commit that referenced this pull request Jul 31, 2013

Merge pull request #192 from slang800/master
removing legacy webkit gradient syntax & other gradient related improvements

@slang800 slang800 merged commit 98de5f1 into tj:master Jul 31, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment