Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Gradients #207

Merged
merged 7 commits into from Jul 30, 2013

Conversation

Projects
None yet
3 participants
Collaborator

slang800 commented Jul 30, 2013

A small chunk of #192

@vendethiel vendethiel commented on the diff Jul 30, 2013

lib/nib/vendor.styl
*/
-replace-args(args,argument,val)
+prepend-args(args, prefix, argument, strict = true)
@vendethiel

vendethiel Jul 30, 2013

I feel bad for having those :(

@slang800

slang800 Jul 30, 2013

Collaborator

in what sense?

@vendethiel

vendethiel Jul 30, 2013

I think these should be handled at the language level

@slang800

slang800 Jul 30, 2013

Collaborator

ah, yeah... that'd be nice :P

@slang800 slang800 added a commit that referenced this pull request Jul 30, 2013

@slang800 slang800 Merge pull request #207 from slang800/gradients
Gradients
760f9f8

@slang800 slang800 merged commit 760f9f8 into tj:master Jul 30, 2013

1 check passed

default The Travis CI build passed
Details

@slang800 slang800 deleted the unknown repository branch Jul 30, 2013

Contributor

kizu commented Jul 30, 2013

It would be nice to cherry-pick this fix too, 'cause right now gradients would be broken for people who use nib only using @import, without JS part, and the fix makes the use() function from the latest Stylus' releases to apply the logic for fixing gradients right inside of .styl file.

Collaborator

slang800 commented Jul 30, 2013

Yep, that'll be merged before the next release... I'm gonna work on merging #192 in small chunks till it's all done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment