Explanation of why this is preferred over siliconforks version. #23

Closed
jamestalmage opened this Issue Jul 5, 2013 · 3 comments

Projects

None yet

2 participants

@jamestalmage

It's not obvious to me why this fork is necessary. Both the current versions of jscoverage, and JSCover work for instrumenting code in node, and with the mocha html-cov reporter as long as you include the --no-highlight flag. i.e.:
jscover --no-highlight lib lib-cov
Am I missing something here?

@tj
Owner
tj commented Jul 5, 2013

it never used to work with node at all, but that was also 3 years ago

@jamestalmage

That is what I gathered after poking around a bit more.

I would recommend one or both of the following:

  1. Have the mocha docs point to JSCover or jscoverage with instructions to use the --no-highlight flag. This tutorial covers pretty much everything.
  2. Update this implementation to allow the --no-highlight flag, so build scripts using it don't break when this version is used.

Alternatively, you could just deprecate this entire repo if you feel the other libraries cover the need. However, I have only tested the other two libraries on OSX 10.8.

@MattiSG MattiSG referenced this issue in MattiSG/Watai Sep 6, 2013
Closed

Re-activate coverage tool #96

@jamestalmage

closed via a08825e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment