Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to define bar cursor #92

Closed
wants to merge 5 commits into from
Closed

Add option to define bar cursor #92

wants to merge 5 commits into from

Conversation

jrouleau
Copy link
Contributor

Simple feature to allow users to customize the last completed character of the progress bar. Includes logic to remove cursor when bar is complete.

@jdan
Copy link
Collaborator

jdan commented Apr 30, 2015

Hmmm, are these used in any CLIs? Nice feature, but I'm not sure how useful it is.

@jrouleau
Copy link
Contributor Author

It's entirely for aesthetics. It's the behaviour of several popular GNU/Linux tools such as pv and wget.

pv
pv

wget
wget

However, I'm noticing now that both of these tools keep the cursor as the last character even after the bar is complete. Here is a comparison. I think I actually like keeping this cursor better.

remove cursor
cursor-remove

keep cursor
cursor-keep

I'm going to update the PR to keep the cursor as that functionality is more common.

@lbeschastny
Copy link

👍 not a very important, but definitely a nice feature.

@ghedamat
Copy link

ghedamat commented Feb 4, 2016

👍 as well! let me know if I can help in get this landed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants