clean up messy stringify tests #25

Closed
tj opened this Issue Nov 22, 2011 · 6 comments

Comments

Projects
None yet
3 participants
Owner

tj commented Nov 22, 2011

No description provided.

Contributor

sebs commented Sep 22, 2013

starting to work on this atm

Contributor

sebs commented Oct 1, 2013

still working on it see here

https://github.com/sebs/node-querystring/

Contributor

sebs commented Oct 5, 2013

I will need some help naming those nested cases. They are not comprehensible to me by just reading the input and output. We could split that up in multiple types of nesting.

Collaborator

buschtoens commented Oct 5, 2013

Can't really help you as I'm on my iPhone right now.

Sometimes we can't really find meaningful names, because the tests grow to abstract. Try using the literal query string. We just have to identify it anyhow.

I'll take a look at your cases anyway and try to come up with names. ;)

Contributor

sebs commented Oct 6, 2013

Cool, since I rewrote all the tests from stringify to parse (#facepalm) ... I have to work a bit more. Its good for the structure though

sebs referenced this issue Oct 9, 2013

Merged

Cleanup of the Tests #81

Contributor

sebs commented Oct 11, 2013

visionmedia#81

Named, resorted and done as far as I am concerned. Please merge or comment ;)

tj closed this in #81 Oct 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment