unescape fallback for malformed uri components #20

Open
wants to merge 3 commits into
from

Projects

None yet

3 participants

denisu commented Aug 28, 2011

instead of just ignoring wrong encoded uri components, we should at least unescape them with the default javascript unescape function, which doesn't break on malformed encodings.

this fixes issues in a messed up iso-8859-1 environment.

Dennis unescape fallback for malformed uri components
instead of just ignoring wrong encoded uri components, we should at leas
t unescape them with the default javascript unescape function, which doe
sn't break on malformed encodings.
140ab27
Owner
tj commented Aug 29, 2011

mind adding a test before I merge?

denisu commented Aug 29, 2011

sure :).

i also added a case to test if iso-8859-1 data is unescaped correctly. i am not sure if this is an issue we should care about though. if it doesn't belong there, leave it out.

Contributor

@denisu wanna rebase by any chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment