[Bug] pomo default break time is 25 min not 5 min?? #36

zlx opened this Issue Feb 5, 2013 · 1 comment

2 participants

zlx commented Feb 5, 2013
config = Pomo::Configuration.load(options.__hash__)
task = Pomo::Break.new('Break time', options.__hash__)
def self.load(options = {})
   options.reject!{|k,v| ![:notifier, :progress, :tmux].include? k}

Because call reject! in the load method so the second options.__hash__ is {}, And it led to default break time to 25

I think save options.__hash__ to one variable and use it for Pomo::Configuration.load and
Pomo::Break.new may solve the problem.

@stephenmckinney stephenmckinney added a commit that closed this issue Feb 9, 2013
@stephenmckinney stephenmckinney Fixes default Break time
Closes #36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment