Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[Bug] pomo default break time is 25 min not 5 min?? #36

Closed
zlx opened this Issue Feb 5, 2013 · 1 comment

Comments

Projects
None yet
2 participants

zlx commented Feb 5, 2013

config = Pomo::Configuration.load(options.__hash__)
task = Pomo::Break.new('Break time', options.__hash__)
def self.load(options = {})
   options.reject!{|k,v| ![:notifier, :progress, :tmux].include? k}

Because call reject! in the load method so the second options.__hash__ is {}, And it led to default break time to 25

I think save options.__hash__ to one variable and use it for Pomo::Configuration.load and
Pomo::Break.new may solve the problem.

Collaborator

stephenmckinney commented Feb 5, 2013

I'm on vacation currently, but will look back into it when I get back home
letter this week.

On Tuesday, February 5, 2013, zlx wrote:

config = Pomo::Configuration.load(options.hash)task = Pomo::Break.new('Break time', options.hash)

def self.load(options = {})
options.reject!{|k,v| ![:notifier, :progress, :tmux].include? k}

Because call reject! in the load method so the second options.hash is
{}, And it led to default break time to 25

I think save options.hash to one variable and use it for
Pomo::Configuration.load and
Pomo::Break.new may solve the problem.


Reply to this email directly or view it on GitHubhttps://github.com/visionmedia/pomo/issues/36.

-Steve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment