Hi, please take commit to add node 0.5.x support #4

Merged
merged 1 commit into from Nov 8, 2011

Conversation

Projects
None yet
3 participants
Contributor

KirillTemnov commented Nov 1, 2011

No description provided.

package.json
@@ -14,5 +14,5 @@
, "superagent": ">= 0.0.1"
}
, "main": "index"
- , "engines": { "node": "0.4.x" }
+ , "engines": { "node": "0.4 || 0.5"}
@tj

tj Nov 1, 2011

Owner

this wont work for 0.6.x which is what 0.5.x will become, so i'd rather do >= 0.4.0 < 0.7.0 or something

Contributor

KirillTemnov commented Nov 1, 2011

I've made updates.

Owner

tj commented Nov 1, 2011

is that syntax right? looks weird

Contributor

KirillTemnov commented Nov 1, 2011

I was try it to launch

$ npm install -g

and all installed without warninngs,

this syntax is unusual, but not weird =)

Owner

tj commented Nov 1, 2011

>= 0.4.0 < 0.7.0 looks a lot more clear to me

Contributor

KirillTemnov commented Nov 1, 2011

Should I make new commit for apply it?

@ghost

ghost commented Nov 8, 2011

Is this now good to go? I'd like to try node 0.6.0 on my project and am blocked by this.

tj added a commit that referenced this pull request Nov 8, 2011

Merge pull request #4 from selead/master
Hi, please take commit to add node 0.5.x support

@tj tj merged commit 3d45295 into tj:master Nov 8, 2011

Should this have made it to the npm repo?

Owner

tj commented Nov 16, 2011

thanks for the reminder, got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment