Skip to content
This repository

Change CassandraDaemon to decrement latch after finished with Cassandra s #120

Merged
merged 1 commit into from over 2 years ago

2 participants

Chris Nauroth Jake Luciani
Chris Nauroth

Hi tjake,

I'm Chris Nauroth. I'm a software engineer at Disney working on a project that integrates with Solandra. I think you've spoken with Arun Jacob. I'm a colleague of his. We're really excited about Solandra, and it's been working great for us so far in a test environment.

I'd like to submit a few patches for your consideration. This is the first one. CassandraUtils.startupServer starts a CassandraDaemon, and then waits on a CountDownLatch for notification that Cassandra initialization has completed. I have some automated integration tests that were sporadically returning from CassandraUtils.startupServer before Cassandra startup had really finished. This patch fixes the issue by reordering some code in CassandraDaemon.java so that it decrements the latch after Cassandra completes initialization (not before).

Thanks,
--Chris

Jake Luciani tjake merged commit 3e70885 into from August 17, 2011
Jake Luciani tjake closed this August 17, 2011
Jake Luciani
Owner

Thanks Chris!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Aug 16, 2011
Chris Nauroth Change CassandraDaemon to decrement latch after finished with Cassand…
…ra startup, not before.
66c7e12
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 1 addition and 4 deletions. Show diff stats Hide diff stats

  1. 5  src/lucandra/CassandraDaemon.java
5  src/lucandra/CassandraDaemon.java
@@ -28,11 +28,8 @@
28 28
     
29 29
     public void start()
30 30
     {
31  
-        
32  
-        startedLatch.countDown();
33  
-        
34  
-        // TODO Auto-generated method stub
35 31
         super.start();
  32
+        startedLatch.countDown();
36 33
     }
37 34
 
38 35
     public CountDownLatch getStartedLatch()
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.