Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

support configuration & env vars #39

Open
woloski opened this Issue May 24, 2012 · 8 comments

Comments

Projects
None yet
3 participants
Contributor

woloski commented May 24, 2012

I would like to have a config.yml scaffolded when creating an app (it should also be added to .gitignore so it does't get added to the repo so we don't disclose keys when using public repos).

The scaffolded .yml file might look like:

# add your own config items that will be accesible using process.env._configkey_

node_env: production

Then we might have a

git azure app --config myapp

That would apply the current config.yml and spawn the env vars for that app on the server.

Owner

tjanczuk commented May 24, 2012

I wonder if this problem isn't already addressed with existing concepts:

  • for security insensitive configuration settings, store them in package.json,
  • for security sensitive configuration settings, use git azure blob to store them in Blob Storage, and if you need to reference a particular blob (e.g. a password or connection string), put the blob name in the package.json file.

This is exactly the approach I am taking with X.509 certificates and associated private keys.

Contributor

woloski commented May 24, 2012

Blob storage sounds good, I forgot you already had a storage account available to use. What do you think of something like:

  • creating a blob (appname.yml) when scaffolding an app (git azure blob --put appname.yml --content "node_env: production")
  • write a very simple config module (maybe a fork of this https://github.com/rjyo/yaml-config-node using blobs instead of fs) and include it as part of the scaffolded app
  • have a way to restart apps (git azure app --restart hello) so that configuration is reloaded
  • setup the env var AUZRE_STORAGE_ACCOUNT and KEY so that it works locally for dev

Regarding env vars, what I like about using them is that it is the universal config system in every cloud platform.

Env Vars are the default nodejs configuration strategy, although I'd love to have a runtime ability like

jitsu set env VARIABLE value

or

heroku config:add VARIABLE=value

I'm working on a new approach. On start_worker if exists I'll call SetEnvVars.cmd which will live on the root of the repo (as package.json) hence it can be changed without repackaging (which has been trouble for me).

I'm working on this right now on my branch, and I'll submit a pull-request afterwards.

Thoughts?

Just to keep the same patterns, file will be called set_env_vars.cmd 😄

Owner

tjanczuk commented Jun 26, 2012

The set_env_vars.cmd will set the same set of environment variables for all applications, and changing them will require bringing down arr.js (which can be done with git azure reset --hard and takes ~2 minutes). If the variables are not security sensitive, perhaps a better approach would be have a section for them in the package.json of individual apps. arr.js can read that section and create appropriate environment block before starting a node.exe to handle a particular application. Moreover, this mechanism composes very well with the existing post-receive hook based mechanism of updating applications: you push changes to environment variables into package.json, and arr.js picks it up just like any other change in the application configuration or code.

I like your idea, a little bit better 😄, I'm playing with
set_env_vars.cmd. I think it's enough for now (not having to recreate the
cspkg, it's huge). However, I'll like yours better.

How would you set the env variables from nodejs?

On Tue, Jun 26, 2012 at 1:40 PM, Tomasz Janczuk <
reply@reply.github.com

wrote:

The set_env_vars.cmd will set the same set of environment variables for
all applications, and changing them will require bringing down arr.js
(which can be done with git azure reset --hard and takes ~2 minutes).
If the variables are not security sensitive, perhaps a better approach
would be have a section for them in the package.json of individual
apps. arr.js can read that section and create appropriate environment block
before starting a node.exe to handle a particular application.
Moreover, this mechanism composes very well with the existing post-receive
hook based mechanism of updating applications: you push changes to
environment variables into package.json, and arr.js picks it up just like
any other change in the application configuration or code.


Reply to this email directly or view it on GitHub:
#39 (comment)

Owner

tjanczuk commented Jun 26, 2012

You need to massage the environment block passed to the new process here: https://github.com/tjanczuk/git-azure/blob/master/src/runtime/arr.js#L715. A good place to do this would be in the getEnv function: https://github.com/tjanczuk/git-azure/blob/master/src/runtime/arr.js#L645-654.


From: johnny.halife [reply@reply.github.com]
Sent: Tuesday, June 26, 2012 11:06 AM
To: Tomasz Janczuk
Subject: Re: [git-azure] support configuration & env vars (#39)

I like your idea, a little bit better 😄, I'm playing with
set_env_vars.cmd. I think it's enough for now (not having to recreate the
cspkg, it's huge). However, I'll like yours better.

How would you set the env variables from nodejs?

On Tue, Jun 26, 2012 at 1:40 PM, Tomasz Janczuk <
reply@reply.github.com

wrote:

The set_env_vars.cmd will set the same set of environment variables for
all applications, and changing them will require bringing down arr.js
(which can be done with git azure reset --hard and takes ~2 minutes).
If the variables are not security sensitive, perhaps a better approach
would be have a section for them in the package.json of individual
apps. arr.js can read that section and create appropriate environment block
before starting a node.exe to handle a particular application.
Moreover, this mechanism composes very well with the existing post-receive
hook based mechanism of updating applications: you push changes to
environment variables into package.json, and arr.js picks it up just like
any other change in the application configuration or code.


Reply to this email directly or view it on GitHub:
#39 (comment)


Reply to this email directly or view it on GitHub:
#39 (comment)

Will do then, I like that better. I'm using the CMD and works fair enough, using the package.json will be even better =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment