Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show album art in list #182

Closed
ZenithDK opened this issue Mar 3, 2016 · 10 comments
Closed

Show album art in list #182

ZenithDK opened this issue Mar 3, 2016 · 10 comments

Comments

@ZenithDK
Copy link

ZenithDK commented Mar 3, 2016

I'm using Mopidy-Tidal to navigate "My Albums" and I notice that Mopidy-Mobile does not show album art for the albums - only for tracks. If I navigate to an artist, only tracks gets album art, not albums.

Not sure if the fault is with Mopidy-Tidal or Mopidy-Mobile.

@tkem
Copy link
Owner

tkem commented Mar 4, 2016

Currently, when browsing, images are shown only for tracks.
With Mopidy >= v1.0, this would also be possible for albums using the new library.get_images() method; will have to look into that, to see if this can easily be done in a backwards-compatzile way to keep MusicBox users happy (still Mopidy v0.19).

@tkem
Copy link
Owner

tkem commented Mar 4, 2016

Mind that your backend will have to support library.get_images(), that's why I didn't use this in the first place; I think there's still not many that do. So it may depend on Mopidy-Tidal to be able to retrieve images for album URIs.

@tkem
Copy link
Owner

tkem commented Mar 4, 2016

@ZenithDK: From your log in #126 it looks like tidal doesn't support get_images(), so this would probably result in a lot of lookups.

@ZenithDK
Copy link
Author

ZenithDK commented Mar 4, 2016

Okay, unfortunately I'm about to move so I shouldn't (and probably won't)
have time to try and fix that.
Will make an issue to track it with the maintainer, though.
Thanks!

On Fri, Mar 4, 2016, 19:12 Thomas Kemmer notifications@github.com wrote:

@ZenithDK https://github.com/ZenithDK: From your log in #126
#126 it looks like tidal
doesn't support get_images(), so this would probably result in a lot of
lookups.


Reply to this email directly or view it on GitHub
#182 (comment).

@tkem
Copy link
Owner

tkem commented Mar 4, 2016

Even with tidal supporting get_images(), MoMo should limit the number of images in one request as in #183. So thanks for bringing this up!

@tkem
Copy link
Owner

tkem commented Mar 4, 2016

And yeah, it's a right kerfuffle you made here ;-)

@tkem
Copy link
Owner

tkem commented Mar 28, 2016

The major problem I see with this is that I'd prefer to load album (and also artist) images only after retrieving the album's/artist's metadata, so this also work with the alternative cover art providers. However, the Mopidy API currently does not provide an efficient API for looking up an album's metadata only, i.e. without looking up all tracks, too; at least none that I'm aware of.

@ZenithDK
Copy link
Author

Is this something we should put in a feature request for mopidy core?

@tkem
Copy link
Owner

tkem commented Mar 29, 2016

IIRC correctly, this has been put up already a couple of times, and is likely to be addressed in the next major API revision (Mopidy 3.0 I think).

@tkem tkem added the blocked label Apr 13, 2016
@tkem
Copy link
Owner

tkem commented Oct 21, 2016

Closing, since I think there's anything MoMo can do about this (short-term).

@tkem tkem closed this as completed Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants