Update for Android #4

Merged
merged 1 commit into from Mar 21, 2012

Conversation

Projects
None yet
3 participants

Check if working on other devices as well

jelmuhr Update for Android, scrollTop did not work correctly. Please check if…
… its working on iPhone and other Android devices as well.
6c82f3d

Now I see where the problem lies. Indeed this modification works great on Android 4 if the navigation should be hidden on page load. Is this the intended behavior? I've originally tested this on an iPod Touch and in the original demo the nav isn't hidden but fully visible on page load. Again this modification solves this on this device too.

The animation could be a nice touch but definitely should be optional. Works well for start page landings but is too obtrusive for users who want to get to the content fast like on single article pages.

Owner

tkenny commented Mar 21, 2012

Thanks kremalicious. The intended behaviour is indeed to hide the navigation on page load.

I haven't been able to test this on Android devices just yet but will go ahead and merge this request as it still works fine on the iPhone I have to test with.

tkenny merged commit 2df14e8 into tkenny:master Mar 21, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment