From 13b64d08ebc77b342329dda8c815eb31c1bfe373 Mon Sep 17 00:00:00 2001 From: GaoXiaodong <13814823514@163.com> Date: Thu, 3 Nov 2022 15:56:45 +0800 Subject: [PATCH] fix(application): update status causes sync release too fast (#2153) Co-authored-by: xdonggao --- pkg/application/controller/app/app_controller.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/application/controller/app/app_controller.go b/pkg/application/controller/app/app_controller.go index 4a28734c7..f1d667a81 100644 --- a/pkg/application/controller/app/app_controller.go +++ b/pkg/application/controller/app/app_controller.go @@ -418,6 +418,9 @@ func (c *Controller) syncAppFromRelease(ctx context.Context, cachedApp *cachedAp } return app, err } + if app.Status.Phase == applicationv1.AppPhaseSucceeded && hasSynced(app) { + return app, nil + } return c.updateStatus(ctx, app, &app.Status, newStatus) }