Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
A way to customize what minor modes jedi:doc can use #29
Hi, thanks for the pull request. However, I am not sure about this change. Because you can already do this:
(setq jedi:doc-mode (lambda () (rst-mode) (view-mode)))
What do you think? What
But I like the idea of calling
It adds convenience. I didn't know you could set minor modes that way until I looked at the source code. Also, the doc for the customization states that it used for setting the major mode. Circumventing the limitation with a lambda function seems kinda "hacky" solution to me especially since it is so easy to add the same functionality to the actual code. :-)
Since jedi:doc-mode is just a symbol that is called, I guess it could be combined with the new customization variable into one variable which has a list of all the modes. jedi:show-doc then would call all those functions in the list.
Another alternative would be to make a hook variable for the jedi doc view, and run all the functions (modes and everything else) attached to that hook when the doc buffer is opened.
You are right about that
Can you rename