Add separate marker ring for goto-definition calls #44
Conversation
It's made to to facilitate popping back to where `C-.` was invoked. Default keybinding is `M-*`.
| @@ -334,6 +338,7 @@ toolitp when inside of function call. | |||
| (define-key map jedi:key-complete 'jedi:complete) | |||
| (define-key map jedi:key-goto-definition 'jedi:goto-definition) | |||
| (define-key map jedi:key-show-doc 'jedi:show-doc) | |||
| (define-key map (kbd "M-*") 'jedi:goto-definition-pop-marker) | |||
There was a problem hiding this comment.
Can you add jedi:key-goto-definition-pop-marker so that it is configurable?
Also please document it in jedi:setup-keys and manual (doc/source/tail.rest).
There was a problem hiding this comment.
FWIW, I agree it should be configurable, more over, M-* has a global binding
There was a problem hiding this comment.
@yyr You are right, thank for the info.
How about C-, or C-*? Both are empty in plain Emacs. I took C-. from M-. of SLIME. SLIME binds M-, (and M-*) for pop so I think it makes sense.
(Stricktly speaking we should bind C-c + punctuation for minor mode but that's why I am not enabling it by default anyway.)
There was a problem hiding this comment.
@yyr, that's actually intentional. I wanted to provide intuitive transition from tags-based browsing to jedi:goto-definition. And you always can do (define-key jedi-mode-map (kbd "M-*") nil) if you miss those tags and don't like the idea. But if you insist... sure.
@tkf, M-. of SLIME was probably an exact same idea: they rebound find-tag function key (also a global binding) to avoid confusion :)
There was a problem hiding this comment.
@immerrr does this totally replace tag based navitaion.? if so I can vote for such keybinding, But after all nothing wrong in making configurable with a defcustom.
There was a problem hiding this comment.
@immerrr If we want jedi:goto-definition-pop-marker to override pop-tag-mark, we should change jedi:goto-definition too. As we discussed in #42 (comment), we may change the default keybind and/or how they are configured soon. For the time being, I want make it consistent. What do you think?
There was a problem hiding this comment.
@tkf sure, no problem
|
Thank you, except the minor points I mentioned it looks fine. I need to check travis failure before merging, though. Probably some package start using functions that are not in 23. |
|
Done. Btw, speaking of key binding conventions, |
|
That's one of the reason why I am not activating it by default. And the reason why I was using that keybinding was to make it compatible with ropemacs. Probably I shouldn't take that keybinding in the first place. |
Add separate marker ring for goto-definition calls
|
Merged. Thanks for patience! |
It's made to to facilitate popping back to where
C-.was invoked.Default keybinding is
M-*.It wasn't too hard, actually.
Feel free to ping me if you insist on having
M-*key customized like the rest of the keybindings. Feel free to close the issue in favor of the pull-request (issue #42).