Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth digest #177

Merged
merged 5 commits into from Jan 27, 2020
Merged

Auth digest #177

merged 5 commits into from Jan 27, 2020

Conversation

@dickmao
Copy link
Collaborator

dickmao commented Jan 26, 2020

@ndw rather than keying off host and port, perhaps it'd be more natural just to key off host?

it'd also be nice to have emacs prompt the user if the auth entry is missing.

ndw and others added 4 commits Jan 26, 2020
dickmao
request.el Show resolved Hide resolved
request.el Outdated Show resolved Hide resolved
request.el Show resolved Hide resolved
dickmao
@dickmao dickmao merged commit 431d143 into master Jan 27, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@dickmao

This comment has been minimized.

Copy link
Collaborator Author

dickmao commented Jan 27, 2020

Your commits have been merged. Thank you.

@ndw

This comment has been minimized.

Copy link
Contributor

ndw commented Jan 27, 2020

Fabulous! Thank you, and thank you for taking the time to show me how my elisp could be improved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.