Allow random expressions as long as they result in a className that begins with css #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkh44
commented
Jul 31, 2017
src/index.js
Outdated
| @@ -244,6 +244,8 @@ function deconstruct (style) { | |||
| } else if (key.indexOf('@supports') === 0) { | |||
| supports = supports || {} | |||
| supports[key] = deconstruct(style[key]) | |||
| } else if (key.indexOf('css-') === 0) { | |||
| plain = { ...plain, ...style[key]} | |||
There was a problem hiding this comment.
silly way to get babels object assign
tkh44
commented
Jul 31, 2017
src/parser.js
Outdated
| } | ||
|
|
||
| // postcss -> js obj | ||
| function objectifyPostcssRules (node) { |
There was a problem hiding this comment.
This function needs to be removed.
tkh44
commented
Jul 31, 2017
src/parser.js
Outdated
| unknownWord (tokens) { | ||
| if (tokens[0][0] === 'word') { | ||
| if (/xxx(\d+)xxx/gm.exec(tokens[0][1])) { | ||
| this.decl(tokens) |
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 90.33% 90.38% +0.04%
==========================================
Files 22 22
Lines 952 967 +15
Branches 255 260 +5
==========================================
+ Hits 860 874 +14
- Misses 74 75 +1
Partials 18 18
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
=========================================
- Coverage 90.12% 89.7% -0.43%
=========================================
Files 22 22
Lines 952 1000 +48
Branches 255 272 +17
=========================================
+ Hits 858 897 +39
- Misses 76 83 +7
- Partials 18 20 +2
Continue to review full report at Codecov.
|
tkh44
changed the title
added 7 commits
August 1, 2017 16:34
…m/tkh44/emotion into random-expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #217
closes #179