Skip to content

Conversation

@cr-tk
Copy link
Collaborator

@cr-tk cr-tk commented Mar 17, 2025

Summary & Motivation (Problem vs. Solution)

The GHSA-4p46-pwfr-66x6 vulnerability in the ring Rust crate was recently published. We think this does not affect production builds of QOS since the issue requires overflow-checks = true, which is not enabled by default on release builds. Additionally, the problem only represents a Denial of Service (DoS) impact and has additional attack requirements, which we think are unlikely to be met in common QOS usage scenarios.

Despite the low risk, the best way forward is to patch the ring crate. The amount of necessary dependency changes is minimal.

How I Tested These Changes

Local tests.

Pre merge check list

  • Update CHANGELOG.MD

@cr-tk cr-tk added the bug Something isn't working label Mar 17, 2025
@cr-tk cr-tk requested a review from a team as a code owner March 17, 2025 19:46
@cr-tk
Copy link
Collaborator Author

cr-tk commented Mar 18, 2025

I've done the dependency security review, namely of the ring crate 0.17.11->0.17.14 diff (we had 0.17.8 here but also trusted 0.17.11 already). For more information, see the corresponding internal documentation.

This is ready for review by a second person.

@r-n-o r-n-o merged commit c4824b3 into main Apr 7, 2025
6 checks passed
@r-n-o r-n-o deleted the christian/update-ring branch April 7, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants