New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "vagrant pluginbundle install" command #6

Closed
tknerr opened this Issue Jun 12, 2013 · 3 comments

Comments

Projects
None yet
1 participant
@tknerr
Owner

tknerr commented Jun 12, 2013

So far we are only checking for required version constraints.

If a plugin requirement is not met, we should now additionally display a message e.g.

plugin 'foo' in version '1.2.3' required. No version found.
plugin 'bar' in version '1.0.0' required. Version '0.9.0' found.

=> run `vagrant plugin bundle_install` to install missing plugin dependencies

When you then run vagrant plugin bundle_install it should uninstall all unmatched plugins and install the missing ones.

Not sure how the command should be named, vagrant plugin bundle_install and vagrant pluginbundle install are just examples...

Maybe we need an uninstall command as well...

@tknerr

This comment has been minimized.

Show comment
Hide comment
@tknerr

tknerr Jun 13, 2013

Owner

started work on the bundle-install branch

some thoughts:

  • is an uninstall command really useful?
  • add additional configuration options we may need:
    • flag whether existing plugins not in the "bundle" should be uninstalled (default: false)
    • flag whether installation should be triggered automatically vs. running vagrant plugin install explicitly (default: false)
Owner

tknerr commented Jun 13, 2013

started work on the bundle-install branch

some thoughts:

  • is an uninstall command really useful?
  • add additional configuration options we may need:
    • flag whether existing plugins not in the "bundle" should be uninstalled (default: false)
    • flag whether installation should be triggered automatically vs. running vagrant plugin install explicitly (default: false)
@tknerr

This comment has been minimized.

Show comment
Hide comment
@tknerr

tknerr Jun 13, 2013

Owner

caveat: don't uninstall self if the above flag is set!

Owner

tknerr commented Jun 13, 2013

caveat: don't uninstall self if the above flag is set!

@tknerr

This comment has been minimized.

Show comment
Hide comment
@tknerr

tknerr Jul 16, 2013

Owner

won't fix - please use https://github.com/fgrehm/vundler instead

Owner

tknerr commented Jul 16, 2013

won't fix - please use https://github.com/fgrehm/vundler instead

@tknerr tknerr closed this Jul 16, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment