diff --git a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/asseteditor/drools/modeldriven/ui/CEPWindowOperatorsDropdown.java b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/asseteditor/drools/modeldriven/ui/CEPWindowOperatorsDropdown.java index 7a38549b67..63d362eec2 100644 --- a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/asseteditor/drools/modeldriven/ui/CEPWindowOperatorsDropdown.java +++ b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/asseteditor/drools/modeldriven/ui/CEPWindowOperatorsDropdown.java @@ -35,7 +35,6 @@ import com.google.gwt.event.shared.HandlerRegistration; import com.google.gwt.user.client.Command; import com.google.gwt.user.client.ui.Composite; -import com.google.gwt.user.client.ui.HasEnabled; import com.google.gwt.user.client.ui.HorizontalPanel; import com.google.gwt.user.client.ui.ListBox; import com.google.gwt.user.client.ui.Widget; @@ -57,7 +56,7 @@ public class CEPWindowOperatorsDropdown extends Composite private HorizontalPanel parametersContainer = new HorizontalPanel(); private HorizontalPanel windowContainer = new HorizontalPanel(); - private boolean isEnabled = true; + private boolean isReadOnly = false; protected HasCEPWindow hcw; @@ -69,8 +68,10 @@ public CEPWindowOperatorsDropdown() { initWidget( windowContainer ); } - public CEPWindowOperatorsDropdown(HasCEPWindow hcw) { + public CEPWindowOperatorsDropdown(HasCEPWindow hcw, + boolean isReadOnly) { this(); + this.isReadOnly = isReadOnly; setCEPWindow( hcw ); } @@ -100,17 +101,6 @@ public String getValue(int index) { return box.getValue( index ); } - public void setEnabled(boolean isEnabled) { - this.isEnabled = isEnabled; - box.setEnabled( isEnabled ); - for ( int iChildWidgetIndex = 0; iChildWidgetIndex < parametersContainer.getWidgetCount(); iChildWidgetIndex++ ) { - Widget childWidget = parametersContainer.getWidget( iChildWidgetIndex ); - if ( childWidget instanceof HasEnabled ) { - ((HasEnabled) childWidget).setEnabled( isEnabled ); - } - } - } - //Additional widget for CEP Window operator parameter private Widget getOperatorExtension() { parametersContainer.setStylePrimaryName( css.container() ); @@ -150,7 +140,7 @@ private void initialiseTextBox(AbstractRestrictedEntryTextBox txt) { value ); } txt.setText( value ); - txt.setEnabled( isEnabled ); + txt.setEnabled( !isReadOnly ); parametersContainer.add( txt ); parametersContainer.setVisible( true ); hcw.getWindow().setParameter( SharedConstants.OPERATOR_PARAMETER_GENERATOR, @@ -163,10 +153,12 @@ private Widget getDropDown() { String selected = ""; String selectedText = ""; - box = new ListBox(); + box = new ListBox(); + box.setEnabled( !isReadOnly ); box.addItem( constants.noCEPWindow(), "" ); + for ( int i = 0; i < operators.size(); i++ ) { String op = operators.get( i ); box.addItem( HumanReadable.getOperatorDisplayName( op ), diff --git a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/asseteditor/drools/modeldriven/ui/FactPatternWidget.java b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/asseteditor/drools/modeldriven/ui/FactPatternWidget.java index ed7f49e650..836f8aca4d 100644 --- a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/asseteditor/drools/modeldriven/ui/FactPatternWidget.java +++ b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/asseteditor/drools/modeldriven/ui/FactPatternWidget.java @@ -538,18 +538,21 @@ private Widget createCEPWindowWidget(final RuleModeller modeller, Label lbl = new Label( constants.OverCEPWindow() ); lbl.setStyleName( "paddedLabel" ); hp.add( lbl ); - CEPWindowOperatorsDropdown cwo = new CEPWindowOperatorsDropdown( c ); - - cwo.addValueChangeHandler( new ValueChangeHandler() { - - public void onValueChange(ValueChangeEvent event) { - setModified( true ); - OperatorSelection selection = event.getValue(); - String selected = selection.getValue(); - c.getWindow().setOperator( selected ); - getModeller().makeDirty(); - } - } ); + CEPWindowOperatorsDropdown cwo = new CEPWindowOperatorsDropdown( c, + readOnly ); + + if ( !this.isReadOnly() ) { + cwo.addValueChangeHandler( new ValueChangeHandler() { + + public void onValueChange(ValueChangeEvent event) { + setModified( true ); + OperatorSelection selection = event.getValue(); + String selected = selection.getValue(); + c.getWindow().setOperator( selected ); + getModeller().makeDirty(); + } + } ); + } hp.add( cwo ); return hp; diff --git a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/asseteditor/drools/modeldriven/ui/templates/TemplateDataCellFactory.java b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/asseteditor/drools/modeldriven/ui/templates/TemplateDataCellFactory.java index 2d0aa3669e..dddd7d2014 100644 --- a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/asseteditor/drools/modeldriven/ui/templates/TemplateDataCellFactory.java +++ b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/asseteditor/drools/modeldriven/ui/templates/TemplateDataCellFactory.java @@ -35,6 +35,7 @@ public class TemplateDataCellFactory extends AbstractCellFactory 0 ) { - PopupDropDownEditCell pudd = new PopupDropDownEditCell(); + PopupDropDownEditCell pudd = new PopupDropDownEditCell( isReadOnly ); pudd.setItems( vals ); cell = new DecoratedGridCellValueAdaptor( pudd, eventBus ); diff --git a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/ConditionPopup.java b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/ConditionPopup.java index 06a571eaf1..bab74b2b1b 100644 --- a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/ConditionPopup.java +++ b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/ConditionPopup.java @@ -777,8 +777,8 @@ private Widget createCEPWindowWidget(final HasCEPWindow c) { lbl.setStyleName( "paddedLabel" ); hp.add( lbl ); - cwo = new CEPWindowOperatorsDropdown( c ); - cwo.setEnabled( !isReadOnly ); + cwo = new CEPWindowOperatorsDropdown( c, + isReadOnly ); if ( !isReadOnly ) { cwo.addValueChangeHandler( new ValueChangeHandler() { diff --git a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/GuidedDecisionTableWidget.java b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/GuidedDecisionTableWidget.java index a4df8288a3..26189f3286 100644 --- a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/GuidedDecisionTableWidget.java +++ b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/GuidedDecisionTableWidget.java @@ -1418,8 +1418,9 @@ private void setupColumnsNote() { } private void setupDecisionTable() { - dtable = new VerticalDecisionTableWidget( new DecisionTableControlsWidget(), + dtable = new VerticalDecisionTableWidget( new DecisionTableControlsWidget( isReadOnly ), getSCE(), + isReadOnly, eventBus ); dtable.setPixelSize( 1000, 400 ); diff --git a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/AbstractPopupEditCell.java b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/AbstractPopupEditCell.java index c43eed5b44..8b5128c866 100644 --- a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/AbstractPopupEditCell.java +++ b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/AbstractPopupEditCell.java @@ -45,6 +45,7 @@ public abstract class AbstractPopupEditCell extends protected final PopupPanel panel; protected final VerticalPanel vPanel; protected final SafeHtmlRenderer renderer; + protected final boolean isReadOnly; protected ValueUpdater valueUpdater; /** @@ -54,11 +55,12 @@ public abstract class AbstractPopupEditCell extends * * @param renderer */ - public AbstractPopupEditCell() { + public AbstractPopupEditCell(boolean isReadOnly) { super( "dblclick", "keydown" ); this.renderer = SimpleSafeHtmlRenderer.getInstance(); this.vPanel = new VerticalPanel(); + this.isReadOnly = isReadOnly; // Pressing ESCAPE dismisses the pop-up loosing any changes this.panel = new PopupPanel( true, @@ -108,6 +110,11 @@ public void onBrowserEvent(Context context, NativeEvent event, ValueUpdater valueUpdater) { + //If read-only ignore editing events + if ( isReadOnly ) { + return; + } + // KeyDown and "Enter" key-press is handled here super.onBrowserEvent( context, parent, diff --git a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/PopupBoundPatternDropDownEditCell.java b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/PopupBoundPatternDropDownEditCell.java index 4647cbd011..dca63f8631 100644 --- a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/PopupBoundPatternDropDownEditCell.java +++ b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/PopupBoundPatternDropDownEditCell.java @@ -37,8 +37,7 @@ * PatternsChangedEvents so that it's content can be maintained as and when * Patterns are added, deleted or edited. */ -public class PopupBoundPatternDropDownEditCell extends - AbstractPopupEditCell +public class PopupBoundPatternDropDownEditCell extends AbstractPopupEditCell implements BoundFactsChangedEvent.Handler { @@ -46,8 +45,9 @@ public class PopupBoundPatternDropDownEditCell extends private final ListBox listBox; - public PopupBoundPatternDropDownEditCell(EventBus eventBus) { - super(); + public PopupBoundPatternDropDownEditCell(EventBus eventBus, + boolean isReadOnly) { + super( isReadOnly ); this.listBox = new ListBox(); // Tabbing out of the ListBox commits changes diff --git a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/PopupDateEditCell.java b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/PopupDateEditCell.java index dd9d9e9fdf..bc8fbc9b31 100644 --- a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/PopupDateEditCell.java +++ b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/PopupDateEditCell.java @@ -33,8 +33,9 @@ public class PopupDateEditCell extends AbstractPopupEditCell { private final DatePicker datePicker; private final DateTimeFormat format; - public PopupDateEditCell(DateTimeFormat format) { - super(); + public PopupDateEditCell(DateTimeFormat format, + boolean isReadOnly) { + super( isReadOnly ); if ( format == null ) { throw new IllegalArgumentException( "format == null" ); } diff --git a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/PopupDropDownEditCell.java b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/PopupDropDownEditCell.java index ceb917a8c9..677c509afd 100644 --- a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/PopupDropDownEditCell.java +++ b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/PopupDropDownEditCell.java @@ -36,8 +36,8 @@ public class PopupDropDownEditCell extends private final ListBox listBox; private String[][] items; - public PopupDropDownEditCell() { - super(); + public PopupDropDownEditCell(boolean isReadOnly) { + super( isReadOnly ); this.listBox = new ListBox(); // Tabbing out of the ListBox commits changes diff --git a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/PopupNumericEditCell.java b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/PopupNumericEditCell.java index a488f34c4a..1f8fb7f45c 100644 --- a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/PopupNumericEditCell.java +++ b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/PopupNumericEditCell.java @@ -41,8 +41,8 @@ public class PopupNumericEditCell extends // A valid number private static final RegExp VALID = RegExp.compile( "(^[-+]?[0-9]*\\.?[0-9]*([eE][-+]?[0-9]*)?$)" ); - public PopupNumericEditCell() { - super(); + public PopupNumericEditCell(boolean isReadOnly) { + super(isReadOnly); this.textBox = new TextBox(); // Tabbing out of the TextBox commits changes diff --git a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/PopupTextEditCell.java b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/PopupTextEditCell.java index 2f970a55ca..0e237956aa 100644 --- a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/PopupTextEditCell.java +++ b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/cells/PopupTextEditCell.java @@ -33,7 +33,11 @@ public class PopupTextEditCell extends AbstractPopupEditCell { private final TextBox textBox; public PopupTextEditCell() { - super(); + this( false ); + } + + public PopupTextEditCell(boolean isReadOnly) { + super( isReadOnly ); this.textBox = new TextBox(); // Tabbing out of the TextBox commits changes diff --git a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/widget/DecisionTableCellFactory.java b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/widget/DecisionTableCellFactory.java index ba9a7f20f0..d24646718c 100644 --- a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/widget/DecisionTableCellFactory.java +++ b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/widget/DecisionTableCellFactory.java @@ -62,14 +62,16 @@ public class DecisionTableCellFactory extends AbstractCellFactory { * * @param sce * SuggestionCompletionEngine to assist with drop-downs - * @param model - * The Decision Table model to assist data-type derivation + * @param isReadOnly + * Should cells be created for a read-only mode of operation * @param eventBus * An EventBus on which cells can subscribe to events */ public DecisionTableCellFactory(SuggestionCompletionEngine sce, + boolean isReadOnly, EventBus eventBus) { super( sce, + isReadOnly, eventBus ); } @@ -207,7 +209,8 @@ public void setModel(GuidedDecisionTable52 model) { } //Drop down of possible patterns - PopupBoundPatternDropDownEditCell pudd = new PopupBoundPatternDropDownEditCell( eventBus ); + PopupBoundPatternDropDownEditCell pudd = new PopupBoundPatternDropDownEditCell( eventBus, + isReadOnly ); BRLRuleModel rm = new BRLRuleModel( model ); pudd.setFactBindings( rm.getLHSBoundFacts() ); return new DecoratedGridCellValueAdaptor( pudd, @@ -242,7 +245,7 @@ public void setModel(GuidedDecisionTable52 model) { } else { // Columns with lists of values, enums etc are always Text (for now) - PopupDropDownEditCell pudd = new PopupDropDownEditCell(); + PopupDropDownEditCell pudd = new PopupDropDownEditCell( isReadOnly ); pudd.setItems( vals ); cell = new DecoratedGridCellValueAdaptor( pudd, eventBus ); @@ -252,7 +255,7 @@ public void setModel(GuidedDecisionTable52 model) { // Make a new Cell for Dialect columns private DecoratedGridCellValueAdaptor makeDialectCell() { - PopupDropDownEditCell pudd = new PopupDropDownEditCell(); + PopupDropDownEditCell pudd = new PopupDropDownEditCell( isReadOnly ); pudd.setItems( DIALECTS ); return new DecoratedGridCellValueAdaptor( pudd, eventBus ); diff --git a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/widget/DecisionTableControlsWidget.java b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/widget/DecisionTableControlsWidget.java index 4f846b684f..53c6738038 100644 --- a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/widget/DecisionTableControlsWidget.java +++ b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/widget/DecisionTableControlsWidget.java @@ -29,56 +29,65 @@ */ public class DecisionTableControlsWidget extends Composite { - protected static final Constants messages = GWT.create(Constants.class); + protected static final Constants messages = GWT.create( Constants.class ); private AbstractDecisionTableWidget dtable; - private Button addRowButton; - private Button otherwiseButton; - private Button analyzeButton; + private Button addRowButton; + private Button otherwiseButton; + private Button analyzeButton; + + private final boolean isReadOnly; public DecisionTableControlsWidget() { + this( false ); + } + + public DecisionTableControlsWidget(final boolean isReadOnly) { + this.isReadOnly = isReadOnly; Panel panel = new HorizontalPanel(); // Add row button - addRowButton = new Button(messages.AddRow(), - new ClickHandler() { - public void onClick(ClickEvent event) { - if (dtable != null) { - dtable.appendRow(); - } - } - }); - panel.add(addRowButton); + addRowButton = new Button( messages.AddRow(), + new ClickHandler() { + public void onClick(ClickEvent event) { + if ( dtable != null ) { + dtable.appendRow(); + } + } + } ); + addRowButton.setEnabled( !isReadOnly ); + panel.add( addRowButton ); - otherwiseButton = new Button(messages.Otherwise(), - new ClickHandler() { - public void onClick(ClickEvent event) { - if (dtable != null) { - dtable.makeOtherwiseCell(); - } - } - }); - otherwiseButton.setEnabled(false); - panel.add(otherwiseButton); + otherwiseButton = new Button( messages.Otherwise(), + new ClickHandler() { + public void onClick(ClickEvent event) { + if ( dtable != null ) { + dtable.makeOtherwiseCell(); + } + } + } ); + otherwiseButton.setEnabled( false ); + panel.add( otherwiseButton ); // Add row button - analyzeButton = new Button(messages.Analyze(), - new ClickHandler() { - public void onClick(ClickEvent event) { - if (dtable != null) { - dtable.analyze(); - } - } - }); - panel.add(analyzeButton); + analyzeButton = new Button( messages.Analyze(), + new ClickHandler() { + public void onClick(ClickEvent event) { + if ( dtable != null ) { + dtable.analyze(); + } + } + } ); + analyzeButton.setEnabled( !isReadOnly ); + panel.add( analyzeButton ); - initWidget(panel); + initWidget( panel ); } /** * Retrieve "otherwise" button - * + * * @return */ Button getOtherwiseButton() { @@ -87,7 +96,7 @@ Button getOtherwiseButton() { /** * Inject DecisionTable to which these controls relate - * + * * @param dtable */ void setDecisionTableWidget(AbstractDecisionTableWidget dtable) { diff --git a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/widget/VerticalDecisionTableWidget.java b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/widget/VerticalDecisionTableWidget.java index 656d742f4d..7f3a98fd73 100644 --- a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/widget/VerticalDecisionTableWidget.java +++ b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/decisiontable/widget/VerticalDecisionTableWidget.java @@ -28,6 +28,7 @@ public class VerticalDecisionTableWidget extends AbstractDecisionTableWidget { public VerticalDecisionTableWidget(DecisionTableControlsWidget ctrls, SuggestionCompletionEngine sce, + boolean isReadOnly, EventBus eventBus) { super( ctrls, sce, @@ -37,9 +38,10 @@ public VerticalDecisionTableWidget(DecisionTableControlsWidget ctrls, //Factories for new cell elements this.cellFactory = new DecisionTableCellFactory( sce, + isReadOnly, eventBus ); this.cellValueFactory = new DecisionTableCellValueFactory( sce ); - + //Date converter is injected so a GWT compatible one can be used here and another in testing DecisionTableCellValueFactory.injectDateConvertor( GWTDateConverter.getInstance() ); diff --git a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/widgets/drools/decoratedgrid/AbstractCellFactory.java b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/widgets/drools/decoratedgrid/AbstractCellFactory.java index fa8b7f0e42..6692fa777c 100644 --- a/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/widgets/drools/decoratedgrid/AbstractCellFactory.java +++ b/guvnor-webapp-drools/src/main/java/org/drools/guvnor/client/widgets/drools/decoratedgrid/AbstractCellFactory.java @@ -37,6 +37,8 @@ public abstract class AbstractCellFactory { protected final SuggestionCompletionEngine sce; + protected final boolean isReadOnly; + protected final EventBus eventBus; /** @@ -44,10 +46,13 @@ public abstract class AbstractCellFactory { * * @param sce * SuggestionCompletionEngine to assist with drop-downs + * @param isReadOnly + * Should cells be created for a read-only mode of operation * @param eventBus * EventBus to which cells can send update events */ public AbstractCellFactory(final SuggestionCompletionEngine sce, + final boolean isReadOnly, final EventBus eventBus) { if ( sce == null ) { throw new IllegalArgumentException( "sce cannot be null" ); @@ -56,6 +61,7 @@ public AbstractCellFactory(final SuggestionCompletionEngine sce, throw new IllegalArgumentException( "eventBus cannot be null" ); } this.sce = sce; + this.isReadOnly = isReadOnly; this.eventBus = eventBus; } @@ -71,25 +77,27 @@ public AbstractCellFactory(final SuggestionCompletionEngine sce, // Make a new Cell for Boolean columns protected DecoratedGridCellValueAdaptor makeBooleanCell() { CheckboxCellImpl cbc = GWT.create( CheckboxCellImpl.class ); + //TODO {manstis} ---> Make read-only return new DecoratedGridCellValueAdaptor( cbc, eventBus ); } // Make a new Cell for Date columns protected DecoratedGridCellValueAdaptor makeDateCell() { - return new DecoratedGridCellValueAdaptor( new PopupDateEditCell( DateTimeFormat.getFormat( DATE_FORMAT ) ), + return new DecoratedGridCellValueAdaptor( new PopupDateEditCell( DateTimeFormat.getFormat( DATE_FORMAT ), + isReadOnly ), eventBus ); } // Make a new Cell for Numeric columns protected DecoratedGridCellValueAdaptor makeNumericCell() { - return new DecoratedGridCellValueAdaptor( new PopupNumericEditCell(), + return new DecoratedGridCellValueAdaptor( new PopupNumericEditCell( isReadOnly ), eventBus ); } // Make a new Cell for a Text columns protected DecoratedGridCellValueAdaptor makeTextCell() { - return new DecoratedGridCellValueAdaptor( new PopupTextEditCell(), + return new DecoratedGridCellValueAdaptor( new PopupTextEditCell( isReadOnly ), eventBus ); }