Skip to content

/alp

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve installation instruction and add homebrew installation instruction #26

Merged
merged 4 commits into from Oct 3, 2019

Conversation

@imbsky
Copy link
Contributor

imbsky commented Oct 3, 2019

No description provided.

@imbsky
Improve installation instruction and add homebrew installation instru…
0c8df71 
…ction
@imbsky imbsky force-pushed the imbsky:patch-1 branch from ca885b3 to 0c8df71 Oct 3, 2019
@imbsky

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

imbsky commented Oct 3, 2019

I squashed commits.
@tkuchiki

This comment has been minimized.

Sign in to view
Copy link
Owner

tkuchiki commented Oct 3, 2019

Thank you for your Pull Request!
I will confirm later.
@imbsky

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

imbsky commented Oct 3, 2019

Added alp to homebrew by Homebrew/homebrew-core#44060. So now we can install it with homebrew.
@tkuchiki
tkuchiki reviewed Oct 3, 2019
View changes
README.ja.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tkuchiki

This comment has been minimized.

Sign in to view
Copy link
Owner

tkuchiki commented Oct 3, 2019

Added alp to homebrew by Homebrew/homebrew-core#44060. So now we can install it with homebrew.

Thank you so much!
@imbsky @tkuchiki
Update README.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
db3707c 
Co-Authored-By: tkuchiki <kuchiki.taku@gmail.com>
@imbsky

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

imbsky commented Oct 3, 2019

I will update README asap.
imbsky added 2 commits Oct 3, 2019
@imbsky
Update README.ja.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
39963d9
@imbsky
Update README.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
0b63f20
@imbsky

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

imbsky commented Oct 3, 2019

I’m happy to help 😄
@tkuchiki
tkuchiki approved these changes Oct 3, 2019
View changes
Copy link
Owner

tkuchiki left a comment

LGTM!
Thank you so much!
@tkuchiki tkuchiki merged commit 49bbe1e into tkuchiki:master Oct 3, 2019
@imbsky imbsky deleted the imbsky:patch-1 branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkuchiki tkuchiki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@imbsky @tkuchiki
You can’t perform that action at this time.