Init callback when hash is empty #2

Closed
cutterax opened this Issue May 17, 2010 · 3 comments

2 participants

@cutterax

if(current_hash) {
_.callback(current_hash);
}

This means that the callback will only run when there is a hash. So the line
$("#load").empty();
in the sample history_test.js will never run. I think the callback should run even though there is no hash since the callback can act accordingly

@tkyk
Owner

$.history.init always executes the callback even if hash is empty. Closed by d44ef54

@cutterax

Well for me it wasn't, i had to change it to
if(current_hash != ''){
}

@tkyk
Owner

I think your problem was fixed at commit d44ef54 and now $.history.init executes the callback even if there is no hash.

If commit d44ef54 is not enough for you, can you make a patch to the latest revision?

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment