Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad invariants in model have a very tiny error icon #235

Closed
fuzz-ai opened this issue Feb 18, 2019 · 10 comments
Closed

Bad invariants in model have a very tiny error icon #235

fuzz-ai opened this issue Feb 18, 2019 · 10 comments
Labels
enhancement Lets change things for the better Toolbox The TLA Toolbox/IDE usability UX design related issues

Comments

@fuzz-ai
Copy link

fuzz-ai commented Feb 18, 2019

If an invariant is mistyped, the error icon that pops up is extremely small and hard to find (and to mouse over in order to see the actual error):

image

(It's that tiny orange x to the bottom left of the invariant selection box.)

Java version: openjdk 10.0.2 2018-07-17
OS: Ubuntu 18.04.2 LTS

@lemmy
Copy link
Member

lemmy commented Feb 18, 2019

Belongs to #49

@fuzz-ai Feel free to add comments for other UI issues to #49

@lemmy lemmy added enhancement Lets change things for the better Toolbox The TLA Toolbox/IDE usability UX design related issues labels Feb 18, 2019
@hwayne
Copy link

hwayne commented Feb 20, 2019

I wonder if there's a way to autopopulate the invariants field and/or make "Add" give a dropdown in addition to a text box...

@fuzz-ai
Copy link
Author

fuzz-ai commented Feb 24, 2019

Similar problem if there are errors in the constants section. If unspecified, or there is an error, the error icon is small, and the error messages are only visible by hovering over it, or hovering over the "N errors detected" at the top of the screen:

image

In addition to being hard to notice, this is also a usability problem in that it's impossible to copy/paste the error messages from here (and I can't see where else they appear.)

@lemmy
Copy link
Member

lemmy commented Feb 24, 2019

@quaeler FYI

@quaeler
Copy link
Contributor

quaeler commented Feb 25, 2019

WRT the icon, we're relying on Eclipse's form's message manager framework (which is there because of the managed forms (which is there because of the form pages which are the model editor pages)) which automatically slaps that icon (FieldDecorationRegistry.DEC_ERROR) on there (hardcoded and immutable in MessageManager.)

We can add some additional UI hints ourselves.

@lemmy
Copy link
Member

lemmy commented Feb 25, 2019

What's the story with regards to Eclipse's forms framework and HiDPI?

@quaeler
Copy link
Contributor

quaeler commented Feb 25, 2019

I believe PDE's plugin editor uses the forms framework, and if so - it looks good at least in 2018-12
screen shot 2019-02-25 at 10 05 34 am

@lemmy
Copy link
Member

lemmy commented Feb 25, 2019

Do you happen to have a screenshot with an (error) icon similar to the one in the Toolbox?

@quaeler
Copy link
Contributor

quaeler commented Feb 25, 2019

Nope... anything i could think of which would be an error condition (negative download sizes, invalid URLs,) were caught on focus loss and reverted rather than displaying an error indication.

@lemmy
Copy link
Member

lemmy commented Apr 20, 2020

Those affected, please open an Eclipse bug. There is nothing that we can do to fix this.

@lemmy lemmy closed this as completed Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Lets change things for the better Toolbox The TLA Toolbox/IDE usability UX design related issues
Projects
None yet
Development

No branches or pull requests

3 participants