Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Allow options to be passed to socket.io #31

Closed
petecoop opened this issue Sep 12, 2016 · 5 comments
Closed

Allow options to be passed to socket.io #31

petecoop opened this issue Sep 12, 2016 · 5 comments
Labels

Comments

@petecoop
Copy link
Contributor

Socket.io has some useful options: https://github.com/socketio/engine.io#methods-1

It'd be nice if we could specify these options in the config to be passed through.

One example use-case is to swap out socket.io's websocket engine with uws: https://github.com/uWebSockets/uWebSockets, which claims to be 10-300x faster than socket.io's default engine (ws)

@tlaverdure
Copy link
Owner

Thanks for sharing. uWebsockets looks pretty interesting, I'll have to check it out. Options for socket.io are on the list.

@tlaverdure
Copy link
Owner

This has been added under the option databaseConfig. See https://github.com/tlaverdure/laravel-echo-server#redis-1

@petecoop
Copy link
Contributor Author

This might allow passing options to the database, but still can't pass options to socket.io which is my issue.

Options would need to be passed here: https://github.com/tlaverdure/laravel-echo-server/blob/master/src/server.ts#L93

@tlaverdure
Copy link
Owner

Oh sorry! Misread this.

@petecoop
Copy link
Contributor Author

nice!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants