Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bolded text in Class Diagram #21

Open
TLChicken opened this issue Nov 12, 2021 · 1 comment
Open

Bolded text in Class Diagram #21

TLChicken opened this issue Nov 12, 2021 · 1 comment

Comments

@TLChicken
Copy link
Owner

TLChicken commented Nov 12, 2021

image.png

Some text in the class diagram are bolded while others are not which is inconsistent

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 16, 2021

Team's Response

Hi! Here is our rationale for our design of the class diagram in response to your issue.

  • Firstly, the font weight ("boldness") of the area you have circled (the *a and *f) is consistent with the font weight of the rest of multiplicity (for e.g., the 1s beside arrows).
  • Secondly, we kept all class names in red boxes un-bolded, and kept all multiplicities at the same font weight. Hence, we have maintained a consistent format for each element of the UML diagram.
  • Thirdly, since we have maintained consistency, there is no problem with the UML diagram. It is not wrong to have different font weights within the same diagram, as different font weights can help emphasise different aspects of the diagram as long as there is consistency in its usage.
  • Finally, the different font weights do not confuse the reader in any way due to our consistency in usage. In fact, using different font weights for different parts of the diagram can aid the reader by providing a visual differentiation between different parts of the diagram (e.g. it is easier for the reader to tell that something is a multiplicity, and not a class name).

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants