?committer search option doesn't work

[zlatanvasovic]

From COMMUNITY-ROLES.md:

Specifically: once a repository collaborator has merged at least 10 PRs (see https://github.com/tldr-pages/tldr/commits?committer=<username>) and submitted at least 5 non-trivial reviews to PRs (see https://github.com/tldr-pages/tldr/pulls?q=reviewed-by:<username>), which can overlap with the 10 they merged themselves, they should be invited to become a member of the tldr-pages organization.

The syntax provided for committer search, i.e. https://github.com/tldr-pages/tldr/commits?committer=<username> doesn't work. The information about committer exists in GitHub API, but it doesn't contain any reference to GitHub username. Do we replace it with some other wording?

[agnivade]

Woops, it should be author, not committer. Good catch @zdroid ! Would you like to open a PR to fix this ?

[zlatanvasovic]

@agnivade I will, but author doesn't show the commits merged by you.

[agnivade]

That's true actually. I don't know of any option that shows merged_by users offhand.

[sbrl]

I use something like this myself:

https://github.com/tldr-pages/tldr/pulls?utf8=%E2%9C%93&q=is%3Apr+author%3A{{username}}

[zlatanvasovic]

@sbrl But again, that shows only the PRs made by you, not the ones merged by you.

[sbrl]

Ah, I misread what you were saying I thought you were talking about the opened 5 PRs one.

[zlatanvasovic]

This is an even bigger problem now, as GitHub often obscures such information. I suggest the requirement for that role being changed into non-trivial review of 10 PRs.

[sbrl]

Hrm. It might be worth implementing a script that determines how many merged PRs each person has.

[zlatanvasovic]

@sbrl Isn't it much easier to just see 10, 15 or 20 non-trivial PR reviews?

cc @agnivade

[agnivade]

I think both are important. Making reviews and writing the pages by themselves. It is the same in a normal codebase where a person should have submitted enough code first to get access. Reviews come after that IMO.

Writing a page from scratch requires you to think about the command, what options are important, in what order to write them and what examples are appropriate. It is good to be in those shoes to get an overall idea of the entire process. It also enables one to make better reviews because one has an idea of the background thinking required to write a page.

[zlatanvasovic]

@agnivade we are talking about "once a repository collaborator has merged at least 10 PRs", not the one before (about having your own PRs merged).

[agnivade]

Ah my bad. Yes, I don't see any big downsides of it.

[zlatanvasovic]

@agnivade downsides of what exactly? What would you suggest to replace the obviously not present option ?committer?

[zlatanvasovic]

Found a solution: https://stackoverflow.com/questions/29277128/find-pull-requests-merged-by-a-specific-user
Is somebody up to write a script for this?