Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ab: add CSV example and update pt_BR translation #11931

Merged
merged 3 commits into from Dec 31, 2023
Merged

Conversation

vitorhcl
Copy link
Member

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.

@github-actions github-actions bot added page edit Changes to an existing page(s). translation Translate pages from one language to another. labels Dec 29, 2023
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages.bn/common/ab.md is outdated, based on number of commands.
  • The page pages.de/common/ab.md is outdated, based on number of commands.
  • The page pages.es/common/ab.md is outdated, based on number of commands.
  • The page pages.fr/common/ab.md is outdated, based on number of commands.
  • The page pages.id/common/ab.md is outdated, based on number of commands.
  • The page pages.it/common/ab.md is outdated, based on number of commands.
  • The page pages.ja/common/ab.md is outdated, based on number of commands.
  • The page pages.ko/common/ab.md is outdated, based on number of commands.
  • The page pages.nl/common/ab.md is outdated, based on number of commands.
  • The page pages.no/common/ab.md is outdated, based on number of commands.
  • The page pages.ru/common/ab.md is outdated, based on number of commands.
  • The page pages.ta/common/ab.md is outdated, based on number of commands.
  • The page pages.zh/common/ab.md is outdated, based on number of commands.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@reinhart1010
Copy link
Collaborator

Wait why are the brackets between numerical examples (like {{100}}) are being removed?

@vitorhcl
Copy link
Member Author

Wait why are the brackets between numerical examples (like {{100}}) are being removed?

It's not because they are numerical values, it's because the description does not suggest that the user can change the value, so it's not really a placeholder. It will be properly docummented in #11946.

@kbdharun kbdharun merged commit c5508a2 into tldr-pages:main Dec 31, 2023
4 checks passed
@vitorhcl vitorhcl deleted the ab branch December 31, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s). translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants