Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

choom: add page #12499

Merged
merged 1 commit into from
Mar 15, 2024
Merged

choom: add page #12499

merged 1 commit into from
Mar 15, 2024

Conversation

vitorhcl
Copy link
Member

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): util-linux 2.39.3

@vitorhcl vitorhcl requested a review from cyqsimon as a code owner March 13, 2024 00:26
@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Mar 13, 2024
@cyqsimon
Copy link
Collaborator

Should we use long form options & flags for simple cases like this?

Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

Should we use long form options & flags for simple cases like this?

Short options are fine here, IG we can leave it as it is or if required we can use the {{-s|--long}} format to highlight both of them.

Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kbdharun kbdharun merged commit f288bf3 into tldr-pages:main Mar 15, 2024
4 checks passed
@vitorhcl vitorhcl deleted the choom-add-page branch March 15, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants