-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runuser: add page #3283
runuser: add page #3283
Conversation
@hieuhtr we will do for sure, don't worry :) we're just a bit over-encumbered right now with the amount of submitted PRs in such a short period of time. At first glance I would suggest to make the description only one line (joining the two together in a single phrase) and change "under substitute" with "as a different". Also, single quotes around "command", "user" and "group" are not needed. |
Co-Authored-By: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
Updated @mebeim, thanks for reviewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got some final adjustment suggestions below. Looks good to me after this.
Co-Authored-By: Marco Bonelli <mebeim@users.noreply.github.com>
Co-Authored-By: Marco Bonelli <mebeim@users.noreply.github.com>
Co-Authored-By: Marco Bonelli <mebeim@users.noreply.github.com>
Co-Authored-By: Marco Bonelli <mebeim@users.noreply.github.com>
Co-Authored-By: Marco Bonelli <mebeim@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you again @hieuhtr, LGTM 👍
common/
,linux/
, etc.)