Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pidstat: add page #3529

Merged
merged 5 commits into from Nov 12, 2019
Merged

pidstat: add page #3529

merged 5 commits into from Nov 12, 2019

Conversation

@einverne
Copy link
Member

einverne commented Nov 6, 2019

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).
@owenvoke owenvoke added the new command label Nov 6, 2019
Copy link
Member

owenvoke left a comment

Hi @einverne, thanks for the new page!

Just a few minor comments I think might make the page clearer.

pages/linux/pidstat.md Outdated Show resolved Hide resolved
pages/linux/pidstat.md Outdated Show resolved Hide resolved
Copy link
Member

schneiderl left a comment

lgtm after @pxgamer's comments are addressed.

pages/linux/pidstat.md Outdated Show resolved Hide resolved
einverne added 2 commits Nov 7, 2019
pages/linux/pidstat.md Outdated Show resolved Hide resolved
pages/linux/pidstat.md Outdated Show resolved Hide resolved
pages/linux/pidstat.md Outdated Show resolved Hide resolved
einverne and others added 2 commits Nov 10, 2019
Copy link
Member

agnivade left a comment

2 and 10 should still be in tokens. I just did the change.

@sbrl
sbrl approved these changes Nov 12, 2019
@sbrl sbrl merged commit 5b34319 into tldr-pages:master Nov 12, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@sbrl

This comment has been minimized.

Copy link
Member

sbrl commented Nov 12, 2019

Merging, since @pxgamer's comments appear to have been addressed and this has been sitting around for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.