Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isosize: add page #4522

Merged
merged 13 commits into from
Oct 6, 2020
Merged

isosize: add page #4522

merged 13 commits into from
Oct 6, 2020

Conversation

en1gma713
Copy link
Contributor

@en1gma713 en1gma713 commented Oct 6, 2020

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@tldr-bot
Copy link

tldr-bot commented Oct 6, 2020

The build for this PR failed with the following error(s):

pages/linux/isosize.md:5: TLDR104 Example descriptions should prefer infinitive tense (e.g. write) over present (e.g. writes) or gerund (e.g. writing)
pages/linux/isosize.md:9: TLDR104 Example descriptions should prefer infinitive tense (e.g. write) over present (e.g. writes) or gerund (e.g. writing)
pages/linux/isosize.md:13: TLDR104 Example descriptions should prefer infinitive tense (e.g. write) over present (e.g. writes) or gerund (e.g. writing)

Please fix the error(s) and push again.

@navarroaxel navarroaxel added the new command Issues requesting creation of a new page. label Oct 6, 2020
@navarroaxel navarroaxel changed the title isosize: add command isosize: add page Oct 6, 2020
Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @en1gma713, thanks for your submission. I left some comments.

pages/linux/isosize.md Outdated Show resolved Hide resolved
pages/linux/isosize.md Outdated Show resolved Hide resolved
pages/linux/isosize.md Outdated Show resolved Hide resolved
pages/linux/isosize.md Outdated Show resolved Hide resolved
pages/linux/isosize.md Outdated Show resolved Hide resolved
pages/linux/isosize.md Outdated Show resolved Hide resolved
pages/linux/isosize.md Outdated Show resolved Hide resolved
Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ Did not meant to approve.

@en1gma713
Copy link
Contributor Author

@navarroaxel in the man page it says that it displays block size but -x or --sectors uses the word sectors instead of blocks

@navarroaxel
Copy link
Member

@en1gma713 you're right. Can we add a link to the man page?

> More information: <https://linux.die.net/man/8/isosize>.

@tldr-bot
Copy link

tldr-bot commented Oct 6, 2020

The build for this PR failed with the following error(s):

Error: Parse error on line 5:
...ze of an iso file.> More information: 
---------------------^
Expecting 'TEXT', 'DASH', 'BACKTICK', got 'GREATER_THAN'

Please fix the error(s) and push again.

@tldr-bot
Copy link

tldr-bot commented Oct 6, 2020

The build for this PR failed with the following error(s):

Error: Parse error on line 5:
...ze of an iso file.> More information: 
---------------------^
Expecting 'TEXT', 'DASH', 'BACKTICK', got 'GREATER_THAN'

Please fix the error(s) and push again.

@tldr-bot
Copy link

tldr-bot commented Oct 6, 2020

The build for this PR failed with the following error(s):

pages/linux/isosize.md:3: TLDR004 Command descriptions should end in a period

Please fix the error(s) and push again.

pages/linux/isosize.md Outdated Show resolved Hide resolved
@tldr-bot
Copy link

tldr-bot commented Oct 6, 2020

The build for this PR failed with the following error(s):

Error: Parse error on line 5:
...ze of an iso file.>More information: h
---------------------^
Expecting 'TEXT', 'DASH', 'BACKTICK', got 'GREATER_THAN'
pages/linux/isosize.md:5: TLDR002 A single space should precede a sentence

Please fix the error(s) and push again.

@tldr-bot
Copy link

tldr-bot commented Oct 6, 2020

The build for this PR failed with the following error(s):

Error: Parse error on line 5:
...ze of an ISO file.> More information: 
---------------------^
Expecting 'TEXT', 'DASH', 'BACKTICK', got 'GREATER_THAN'

Please fix the error(s) and push again.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me when when @navarroaxel's comments are addressed

@en1gma713
Copy link
Contributor Author

done

Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @en1gma713 the page is OK, you have only 3 minor changes.


- Display the size of an iso file divided by a given number (only usable when -x is not given):

`isosize -d {{number}} {{path/to/file.iso}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`isosize -d {{number}} {{path/to/file.iso}}`
`isosize --divisor={{number}} {{path/to/file.iso}}`

@navarroaxel navarroaxel merged commit 05964eb into tldr-pages:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants