-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isosize: add page #4522
isosize: add page #4522
Conversation
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @en1gma713, thanks for your submission. I left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️ Did not meant to approve.
@navarroaxel in the man page it says that it displays block size but -x or --sectors uses the word sectors instead of blocks |
@en1gma713 you're right. Can we add a link to the man page?
|
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me when when @navarroaxel's comments are addressed
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @en1gma713 the page is OK, you have only 3 minor changes.
pages/linux/isosize.md
Outdated
|
||
- Display the size of an iso file divided by a given number (only usable when -x is not given): | ||
|
||
`isosize -d {{number}} {{path/to/file.iso}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`isosize -d {{number}} {{path/to/file.iso}}` | |
`isosize --divisor={{number}} {{path/to/file.iso}}` |
common/
,linux/
, etc.)