Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows/*: add page #8783

Merged
merged 12 commits into from Dec 21, 2022
Merged

Conversation

fcrespo82
Copy link
Contributor

@fcrespo82 fcrespo82 commented Oct 6, 2022

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.

Thanks for this amazing project. Many times I needed to know how to run a command but the help/manpage was too complex.

I'm still working on adding more commands to this PR. Please hold from verifying until done.

Question: I noticed that some PowerShell related aliases have the same name of other tools. Is it possible to group utility related commands in a sub folder for disambiguation?

eg:

pages/
  windows/
    powershel/
      where.md
      ...

For #6621

@CLAassistant

This comment was marked as outdated.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 6, 2022
@fcrespo82 fcrespo82 changed the title [WIP] out-string, pwsh-where, select-string, sls, where-object: add page [WIP] out-string, select-string, sls, where-object, pwsh-where, start-service, stop-service, set-service, show-markdown, resolve-path: add page Oct 9, 2022
@fcrespo82 fcrespo82 changed the title [WIP] out-string, select-string, sls, where-object, pwsh-where, start-service, stop-service, set-service, show-markdown, resolve-path: add page [WIP] Add page for multiple new PowerShell commands Oct 11, 2022
@kbdharun kbdharun added the review needed Prioritized PRs marked for reviews from maintainers. label Oct 14, 2022
@fcrespo82 fcrespo82 changed the title [WIP] Add page for multiple new PowerShell commands Add pages for multiple new PowerShell commands Oct 18, 2022
@fcrespo82
Copy link
Contributor Author

Hi @kbdharun, @navarroaxel

I think I'm done for now.

@marchersimon
Copy link
Collaborator

Hey @fcrespo82, thanks for your engagement. Unfortunately we always have to reject suggestions concerning the structure of the pages. There are so much different clients by now and every one of them is maintained by someone else. Changing the directory structure would break all those clients and it's impossible to ensure, that every one gets updated to meet the new specification.

@marchersimon
Copy link
Collaborator

marchersimon commented Oct 18, 2022

Sorry, I though this PR was about adding this new powershell directory. As already said we can't do that but new pages in the existing directories are always welcome.

Edit: Such big PRs like this can take some time to be reviewed, especially now during Hacktober, just fyi.

@fcrespo82
Copy link
Contributor Author

Sorry for the confusion. I did mention the change of structure in the PR, but not changed anything without consent.

This is still only adding pages.

I appreciate the effort to review the PR.

Thanks again for the tool.

pages/windows/get-date.md Outdated Show resolved Hide resolved
pages/windows/get-acl.md Outdated Show resolved Hide resolved
pages/windows/get-acl.md Outdated Show resolved Hide resolved
pages/windows/get-acl.md Outdated Show resolved Hide resolved
pages/windows/get-date.md Outdated Show resolved Hide resolved
pages/windows/test-json.md Outdated Show resolved Hide resolved
pages/windows/test-json.md Outdated Show resolved Hide resolved
pages/windows/test-json.md Outdated Show resolved Hide resolved
pages/windows/test-json.md Outdated Show resolved Hide resolved
pages/windows/test-json.md Outdated Show resolved Hide resolved
@navarroaxel navarroaxel changed the title Add pages for multiple new PowerShell commands windows/*: add page Oct 20, 2022
@kbdharun
Copy link
Member

kbdharun commented Oct 22, 2022

Update: I updated the PR description to refer to Issue #6621 by @reinhart1010. I didn't use closes in the description as there seem to be more commandlets left to document.

@fcrespo82
Copy link
Contributor Author

@navarroaxel I made all suggested changes.

Thanks for the review.

pages/windows/select-string.md Show resolved Hide resolved
pages/windows/set-date.md Outdated Show resolved Hide resolved
pages/windows/set-date.md Outdated Show resolved Hide resolved
pages/windows/measure-object.md Outdated Show resolved Hide resolved
pages/windows/resolve-path.md Outdated Show resolved Hide resolved
pages/windows/select-string.md Outdated Show resolved Hide resolved
pages/windows/set-service.md Outdated Show resolved Hide resolved
pages/windows/set-service.md Outdated Show resolved Hide resolved
pages/windows/stop-service.md Outdated Show resolved Hide resolved
pages/windows/stop-service.md Outdated Show resolved Hide resolved
pages/windows/start-service.md Outdated Show resolved Hide resolved
pages/windows/start-service.md Outdated Show resolved Hide resolved
pages/windows/start-service.md Outdated Show resolved Hide resolved
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/windows/resolve-path.md:12: TLDR103 Command example is missing its closing backtick

Please fix the error(s) and push again.

fcrespo82 and others added 2 commits October 25, 2022 09:59
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@fcrespo82 fcrespo82 requested review from navarroaxel and kbdharun and removed request for mfrw, reinhart1010, marchersimon and navarroaxel October 26, 2022 01:25
@kbdharun kbdharun mentioned this pull request Oct 28, 2022
5 tasks
@kbdharun kbdharun added the hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. label Oct 29, 2022
@github-actions
Copy link

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label Nov 14, 2022
Copy link
Collaborator

@reinhart1010 reinhart1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good enough.

@reinhart1010 reinhart1010 removed the waiting Issues/PRs with Pending response by the author. label Dec 21, 2022
@reinhart1010 reinhart1010 merged commit aed3404 into tldr-pages:main Dec 21, 2022
@pixelcmtd pixelcmtd removed the review needed Prioritized PRs marked for reviews from maintainers. label Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants