Associate buffers with the last frame in which they appeared #30

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

so when emacs automatically chooses a buffer to fill a window, it comes "from the current workgroup."

Fixes #23

Associate buffers with the last frame in which they appeared, so when…
… emacs automatically chooses a buffer to fill a window, it comes "from the current workgroup."


Fixes #23

qdot commented Jul 28, 2012

I just tried merging this and it doesn't seem to do what I think it's supposed to? Right now I have the problem where if I bring up a buffer, then switch workgroups, then switch back and kill the buffer I brought up, it puts me in the last active buffer from the last workgroup I switched to, instead of the last visited buffer in the workgroup before I switched. Is this supposed to fix that? I'm not sure if I'm thinking about this correctly or not since this bug references frames and I'm only using a single frame.

Yes, this is supposed to fix that. I am usually only using a single frame myself.

Note: I just discovered that I haven't had this patch in my emacs for some time. When I try your sequence of operations, it indeed does not work as you expect. I'll have a look.

qdot commented Jul 28, 2012

While we're at it, are you still using workgroups much? It seems that some of the #emacs crew is migrating away due to lack of upkeep. I've at least forked and want to do some improvements, but not sure if I have time. Just trying to get an idea of how much others are still using it.

Yep, I use it all the time

My code doesn't handle this case. The code that chooses replacement buffers after a buffer is killed doesn't seem to consult the buffer-predicate frame parameter. IMO you should report that as a bug upstream. In the meantime, you might try https://github.com/dabrahams/dwamacs/blob/master/site-lisp/wg-bufs.el

I'm afraid I don't know where I found this file. I note that I haven't been using it.

qdot commented Jul 28, 2012

Hmm, ok, I should check out where the buffer replacement happens and see if I can patch it myself, that's a huge problem for me lately.

The wg-bufs stuff looks kind of like what wg-buffer-list-filter-* does in experimental. Might give it a shot though, since I've had loads of problems with buffer-list-filter not working right. Thanks!

The fact that this doesn't work is an emacs bug. The thread contains a patch. See http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg01118.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment