From 79b7c0d0fab40fea06fc3761c60c1d0ed4c4c498 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Linhart?= Date: Mon, 5 Jun 2023 13:45:47 +0200 Subject: [PATCH] Fix login loop Setting `SameSite=None` also requires setting `Secure`, see https://web.dev/samesite-cookies-explained/#samesite=none-must-be-secure. Fixes #4 --- index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.js b/index.js index 1400df1..61c82e4 100644 --- a/index.js +++ b/index.js @@ -19,7 +19,7 @@ module.exports = Franz => class MicrosoftTeams extends Franz { onHeadersReceived(details, callback) { if (details.responseHeaders && details.responseHeaders['Set-Cookie'] && details.responseHeaders['Set-Cookie'].length && !details.responseHeaders['Set-Cookie'][0].includes('SameSite=none')) { // eslint-disable-next-line no-param-reassign - details.responseHeaders['Set-Cookie'][0] = `${details.responseHeaders['Set-Cookie'][0]}; SameSite=none`; + details.responseHeaders['Set-Cookie'][0] = `${details.responseHeaders['Set-Cookie'][0]}; SameSite=none; Secure`; } callback({ cancel: false, responseHeaders: details.responseHeaders }); }