New option functions #19

Closed
wants to merge 8 commits into
from

Projects

None yet

2 participants

@jayj
jayj commented Mar 29, 2012

Create two new option functions. One to get the default options and one to return an array with the options. This will elimate the need of global variables.

You should also consider to remove the JS from header.php and footer.php, create a function and attach it to the wp_footer action so it runs after jQuery is included.

Ignore the two oldest commits. Apparently I didn't fix the problem and they're still in my pull requests.

jayj added some commits Mar 28, 2012
@jayj jayj Update readme and test if this thing is working 3aa8aa0
@jayj jayj * Fix PHP notices because of undefined variables in the comment funct…
…ion.

* Make the comment markup cleanier and more HTML5 + some styling "fixing"
* The placeholder attributes on the comment fields have been removed. I don't really like them and IMO they just add clutter to the page.
* Clean up spacing issues in the affected functions (and a few more)
9b620f5
@jayj jayj Use wp_enqueue_scripts() to add styles instead of wp_print_styles(). … 999e3c5
@jayj jayj Create two new option functions. One to get the default options and o…
…ne to return an array with the options. This will elimate the need of global variables.
391526a
@jayj jayj Update attachments.php
* Use the new option functions
* Fix notice caused by lowercase $post->id
* Code clean-up
* Use of printf in the i18n strings
e989f99
@jayj jayj Update footer.php to the new option functions and make use of printf …
…to make it easier for translators to translate.

@suggestion Move the JS out of this file into their own function and attach it the wp_footer action.
1a5206d
@jayj jayj Update header.php to the new options functions.
Also specify 'theme_location' in the wp_nav_menu() call.
e298231
@jayj jayj Update the comment pagination in comments.php to match each other. 110828e
@tlongren tlongren was assigned Mar 30, 2012
@tlongren
Owner

I pulled these changes in manually.

@tlongren tlongren closed this Mar 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment