Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Simple Server should be able to be stopped via a signal #11

Open
nrstott opened this Issue Oct 29, 2009 · 2 comments

Comments

Projects
None yet
2 participants

nrstott commented Oct 29, 2009

Shouldn't have to kill the process to stop it. It should be able to be stopped by a signal on unix or by a command sent to a port other than the web listening port on windows. I'm not so sure that's how it should be done on windows, any ideas about that?

nrstott commented Oct 29, 2009

Well I took a stab at doing this in a totally different way to make it easily cross platform. I made a second port that the simple handler listens on for commands and I implemented a stop command. It would be up to the administrator to insure this port was not available to those who it should not be available to.

Using curl to stop the server seems simple and elegant. Let me know your thoughts.

http://github.com/nrstott/jack/commit/fbe138dc2848c8256148aa0d5559811c78afcc25

Owner

tlrobinson commented Nov 20, 2009

Seems reasonable. Though we should probably make it opt-in though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment