Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

readline module not working in debugger #69

Open
kriszyp opened this Issue Nov 12, 2009 · 3 comments

Comments

Projects
None yet
2 participants

kriszyp commented Nov 12, 2009

readline should use the Rhino's shell input, rather than going directly to jline, so that
jline works in both debugger and command line:
http://github.com/kriszyp/narwhal/commit/7bbdce2ed704503f0156ef6a59da08a801a722df

Owner

tlrobinson commented Nov 20, 2009

The readline package is supposed to be generic, but the Rhino shell input has JavaScript specific behavior. Maybe we should just detect Rhino in the REPL and use this there?

kriszyp commented Nov 25, 2009

I thought that the repl module was supposed engine/platform agnostic, whereas the readline package would handle adapting to different engines. Rhino is certainly one of the engines, so shouldn't this be detected and handled at the readline level? If you want the detection move to the repl module, I can do that, just wanted to make sure.

Owner

tlrobinson commented Nov 26, 2009

By "generic" I mean it implements a generic readline prompt, not one which includes JavaScript autocompletion, etc. You should be able to use the plain "readline" module for any sort of REPL, not just JavaScript.

I would be ok with having, say, a "readline/javascript" module (or readline.readLineJS()) or something like that, which uses the Rhino REPL, and falls back to the standard readline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment