zip module does not have close method #73

Open
kriszyp opened this Issue Nov 18, 2009 · 3 comments

Comments

Projects
None yet
2 participants

kriszyp commented Nov 18, 2009

The zip module does not have a close method, and so calling unzip leaves the file in an open/locked state. Fix is here:
http://github.com/kriszyp/narwhal/commit/27b49bfe9c5372f820f3130d302606b797f8c24a

Collaborator

kriskowal commented Nov 21, 2009

Landed in kriskowal/master kriskowal/refactor. I cherry-picked; you're tracking cadorn's stuff, right? Does it work for you?

kriszyp commented Nov 21, 2009

I have pulled in cadorn's master, and unzip still works with it. Or are you saying that cadorn's master should fix unzip to close? I don't see anything in cadorn's zip.js that would close.

Collaborator

kriskowal commented Nov 21, 2009

No, unrelated; tusk does not work for me on cadorn/experimental and was wondering if anyone else had succeeded in using it. So it would seem; I'll have to look deeper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment