Tom Robinson
tlrobinson

Developer Program Member

Organizations

@cappuccino @robohornet @webpipes @metabase
Aug 26, 2016
@tlrobinson
  • @tlrobinson 43d63bb
    Pie: hide percent in tooltip if metric is named percent
Aug 26, 2016
@tlrobinson
Aug 26, 2016
tlrobinson commented on issue metabase/metabase#2861
@tlrobinson

Regarding the duplicate "percentage" tooltip, I see 2 options: Add YAT (yet another knob) to hide it Use some heuristic (column name is /^percent.…

Aug 26, 2016
tlrobinson commented on issue metabase/metabase#3271
@tlrobinson

The top answer on that SO question says According to the Unicode standard, the BOM for UTF-8 files is not recommended. Is there another way we coul…

Aug 24, 2016
tlrobinson commented on pull request metabase/metabase#3264
@tlrobinson

👍

Aug 24, 2016
tlrobinson commented on pull request metabase/metabase#3264
@tlrobinson

Yeah, what @camsaul said

Aug 24, 2016
tlrobinson commented on pull request metabase/metabase#3264
@tlrobinson

LGTM except this console.log. I'd also probably do a switch statement orconst display = ...` at the top, but not a big deal.

Aug 24, 2016
@tlrobinson
  • @tlrobinson 3111cca
    Initial frontend implementation of custom maps
Aug 24, 2016
Aug 23, 2016
tlrobinson commented on issue metabase/metabase#3260
@tlrobinson

As part of this we should explore supporting joins across multiple tables #1173 IIRC the QP already supports it, it's just not exposed on the fron…

Aug 23, 2016
tlrobinson commented on pull request metabase/metabase#3256
@tlrobinson

I'm going to go ahead and do the frontend on this branch too, if that's ok. #2740

Aug 23, 2016
@tlrobinson
tlrobinson deleted branch sql-bracket-matching at metabase/metabase
Aug 23, 2016
Aug 23, 2016
tlrobinson merged pull request metabase/metabase#3108
@tlrobinson
Add bracket/paren/braces matching to SQL editor
2 commits with 285 additions and 5 deletions
Aug 23, 2016
@tlrobinson
tlrobinson deleted branch fix-password-reset-check at metabase/metabase
Aug 23, 2016
Aug 23, 2016
tlrobinson merged pull request metabase/metabase#3225
@tlrobinson
Replace angular mb-icon directive with icon component on password reset.
1 commit with 4 additions and 2 deletions
Aug 23, 2016
tlrobinson commented on pull request metabase/metabase#3144
@tlrobinson

Oh area you trying to render multiple tooltips at the same time as you have in the screenshot? @mazameli How is this looking design-wise?

Aug 23, 2016
tlrobinson commented on pull request metabase/metabase#3144
@tlrobinson

@mavimo You don't need to render the Tooltip yourself, you just call the onHoverChange prop and the parent component will display the tooltip for you.

Aug 23, 2016
tlrobinson commented on issue metabase/metabase#2861
@tlrobinson

@mazameli @kdoh Any ideas how to handle overflowing labels in the center (last screenshot)?

Aug 23, 2016
tlrobinson commented on pull request metabase/metabase#3225
@tlrobinson

👍

Aug 23, 2016
@tlrobinson
  • @tlrobinson 3821e85
    Merge pull request #3229 from metabase/hide-schema-arrow
  • @lewisl9029 6b63139
    Hide single section title instead to avoid unlimited list height
  • 1 more commit »
tlrobinson deleted branch hide-schema-arrow at metabase/metabase
Aug 23, 2016
Aug 23, 2016
tlrobinson merged pull request metabase/metabase#3229
@tlrobinson
Hide expand/collapse arrow in query builder when selecting fields from a single table
2 commits with 1 addition and 0 deletions
Aug 23, 2016
@tlrobinson
Up arrow in data selector should only appear on DBs with multiple schemas
Aug 23, 2016
tlrobinson commented on pull request metabase/metabase#3212
@tlrobinson

Yeah I'm pretty sure they're supposed to do the same thing. Your implementation looks good, just remove hasUnmappedParameters and this should be fine.

Aug 23, 2016
tlrobinson commented on pull request metabase/metabase#3108
@tlrobinson

@salsakran Any additional thoughts on this?

tlrobinson deleted branch release-0.19.3 at metabase/metabase
Aug 23, 2016
Aug 23, 2016
@tlrobinson
tlrobinson deleted branch fix-datamodel-schema-picker at metabase/metabase
Aug 23, 2016