Skip to content

Fix ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD SpotBugs issue #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

Fix ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD SpotBugs issue #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions src/main/java/de/rub/nds/crawler/persistence/MongoPersistenceProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,18 @@ public class MongoPersistenceProvider implements IPersistenceProvider {

private static final String BULK_SCAN_COLLECTION_NAME = "bulkScans";

private static boolean isInitialized = false;
private static final Set<JsonSerializer<?>> serializers = new HashSet<>();
private static final Set<Module> modules = new HashSet<>();
private static final Object registrationLock = new Object();
private static volatile boolean registrationClosed = false;

public static void registerSerializer(JsonSerializer<?> serializer) {
if (isInitialized) {
throw new RuntimeException("Cannot register serializer after initialization");
synchronized (registrationLock) {
if (registrationClosed) {
throw new RuntimeException("Cannot register serializer after initialization");
}
serializers.add(serializer);
}
serializers.add(serializer);
}

public static void registerSerializer(JsonSerializer<?>... serializers) {
Expand All @@ -68,10 +71,12 @@ public static void registerSerializer(JsonSerializer<?>... serializers) {
}

public static void registerModule(Module module) {
if (isInitialized) {
throw new RuntimeException("Cannot register module after initialization");
synchronized (registrationLock) {
if (registrationClosed) {
throw new RuntimeException("Cannot register module after initialization");
}
modules.add(module);
}
modules.add(module);
}

public static void registerModule(Module... modules) {
Expand Down Expand Up @@ -148,7 +153,9 @@ private static ObjectMapper createMapper() {
* @param mongoDbDelegate Mongodb command line configuration parameters
*/
public MongoPersistenceProvider(MongoDbDelegate mongoDbDelegate) {
isInitialized = true;
synchronized (registrationLock) {
registrationClosed = true;
}

mapper = createMapper();
mongoClient = createMongoClient(mongoDbDelegate);
Expand Down