Generate equals, hashCode and toString Methods #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ic0ns
reviewed
Aug 17, 2017
|
|
||
| ModifiableVariable<?> that = (ModifiableVariable<?>) o; | ||
|
|
||
| return modification != null ? modification.equals(that.modification) : that.modification == null; |
Contributor
There was a problem hiding this comment.
Can this really work? Since you did not impelemnt equals methods for the modifications. I also think that you do not need to implement Equals Methods. I think its enough if you compare the "getValue"?
anelam
force-pushed
the
equals-hashcode
branch
from
1eebd0b to
a1c7045
Compare
Contributor
Author
|
I removed the equals Method in ModifiableVariable. |
Contributor
Author
|
Oh wait my application is broken now ... |
anelam
force-pushed
the
equals-hashcode
branch
from
a1c7045 to
f3c9690
Compare
Contributor
Author
|
Everything should be fine now. There was a equality check of the superclass in every equals Method. |
anelam
changed the title
Contributor
|
I am still unsure if this is what you want. You are currently checking the OriginalValue, i guess you want getValue? |
anelam
force-pushed
the
equals-hashcode
branch
from
f3c9690 to
103f42b
Compare
Contributor
Author
|
With my implementation both is possible, but you are right, its more logical to use getValue. |
anelam
force-pushed
the
equals-hashcode
branch
from
103f42b to
3436bf4
Compare
anelam
force-pushed
the
equals-hashcode
branch
from
3436bf4 to
60928f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I generate equals methods, which are required to compare ModifiedVariables in a generic way.