From 68bca33539de7033a56ddf22c56665ba90951710 Mon Sep 17 00:00:00 2001 From: TLS-Attacker Developer Date: Mon, 30 Jun 2025 09:28:45 +0000 Subject: [PATCH] fix: Update javadoc comments to reference DataConverter instead of deprecated ArrayConverter - Updated javadoc comments in ByteArrayAppendValueModification - Updated javadoc comments in ByteArrayDuplicateModification - Updated javadoc comments in ByteArrayInsertValueModification - Updated javadoc comments in ByteArrayPrependValueModification All actual code references to ArrayConverter have already been migrated to DataConverter. This commit only updates the documentation to reflect the current implementation. --- .../bytearray/ByteArrayAppendValueModification.java | 4 ++-- .../bytearray/ByteArrayDuplicateModification.java | 2 +- .../bytearray/ByteArrayInsertValueModification.java | 2 +- .../bytearray/ByteArrayPrependValueModification.java | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/java/de/rub/nds/modifiablevariable/bytearray/ByteArrayAppendValueModification.java b/src/main/java/de/rub/nds/modifiablevariable/bytearray/ByteArrayAppendValueModification.java index 96ee20d2..7ba7a2a4 100644 --- a/src/main/java/de/rub/nds/modifiablevariable/bytearray/ByteArrayAppendValueModification.java +++ b/src/main/java/de/rub/nds/modifiablevariable/bytearray/ByteArrayAppendValueModification.java @@ -82,8 +82,8 @@ public ByteArrayAppendValueModification createCopy() { * Modifies the input by appending bytes to the end of the array. * *

This method concatenates the bytes to append to the end of the input byte array using the - * ArrayConverter's concatenate method. A new byte array is created with the original input - * bytes followed by the bytes to append. + * DataConverter's concatenate method. A new byte array is created with the original input bytes + * followed by the bytes to append. * *

Note that this operation creates a new array that is longer than the original input by the * length of the bytes to append. The original input remains unchanged. diff --git a/src/main/java/de/rub/nds/modifiablevariable/bytearray/ByteArrayDuplicateModification.java b/src/main/java/de/rub/nds/modifiablevariable/bytearray/ByteArrayDuplicateModification.java index d3b73fa5..2bdf6e00 100644 --- a/src/main/java/de/rub/nds/modifiablevariable/bytearray/ByteArrayDuplicateModification.java +++ b/src/main/java/de/rub/nds/modifiablevariable/bytearray/ByteArrayDuplicateModification.java @@ -59,7 +59,7 @@ public ByteArrayDuplicateModification createCopy() { * copy of itself, effectively doubling the length of the array. The operation preserves the * original array's contents and ordering, simply repeating it. * - *

The implementation uses the ArrayConverter's concatenate method for efficient array + *

The implementation uses the DataConverter's concatenate method for efficient array * manipulation and guarantees that the original array is not modified, maintaining * immutability. * diff --git a/src/main/java/de/rub/nds/modifiablevariable/bytearray/ByteArrayInsertValueModification.java b/src/main/java/de/rub/nds/modifiablevariable/bytearray/ByteArrayInsertValueModification.java index 60b42a0c..7c808c5b 100644 --- a/src/main/java/de/rub/nds/modifiablevariable/bytearray/ByteArrayInsertValueModification.java +++ b/src/main/java/de/rub/nds/modifiablevariable/bytearray/ByteArrayInsertValueModification.java @@ -97,7 +97,7 @@ public ByteArrayInsertValueModification createCopy() { *

  • If the position exceeds the array length, it's adjusted using modulo arithmetic * * - *

    The implementation uses ArrayConverter for efficient concatenation operations, ensuring + *

    The implementation uses DataConverter for efficient concatenation operations, ensuring * optimal performance even with large arrays. * * @param input The original byte array diff --git a/src/main/java/de/rub/nds/modifiablevariable/bytearray/ByteArrayPrependValueModification.java b/src/main/java/de/rub/nds/modifiablevariable/bytearray/ByteArrayPrependValueModification.java index 7e329309..de020015 100644 --- a/src/main/java/de/rub/nds/modifiablevariable/bytearray/ByteArrayPrependValueModification.java +++ b/src/main/java/de/rub/nds/modifiablevariable/bytearray/ByteArrayPrependValueModification.java @@ -83,7 +83,7 @@ public ByteArrayPrependValueModification createCopy() { * Modifies the input by prepending bytes to the beginning of the array. * *

    This method concatenates the bytes to prepend with the input byte array using the - * ArrayConverter's concatenate method. A new byte array is created with the bytes to prepend at + * DataConverter's concatenate method. A new byte array is created with the bytes to prepend at * the beginning followed by the original input bytes. * *

    Note that this operation creates a new array that is longer than the original input by the