Readme updates #140
Merged
Readme updates #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomato42
added
the
maintenance
tomato42
force-pushed
the
readme-updates
branch
2 times, most recently
from
c2e39d7 to
a21c000
Compare
simo5
approved these changes
Oct 21, 2019
simo5
left a comment
simo5
left a comment
There was a problem hiding this comment.
Minor nits to the language, otherwise looks good.
The RF/power consumption part is a bit dramatic but hey, it's true :)
README.md
Outdated
| 224, 256, 384, and 521 bits. The "short names" for these curves, as known by | ||
| the OpenSSL tool (`openssl ecparam -list_curves`), are: `prime192v1`, | ||
| `secp224r1`, `prime256v1`, `secp384r1`, and `secp521r1`. It also includes the | ||
| 256-bit curve used by Bitcoin, whose short name is `secp256k1`. No other curves |
There was a problem hiding this comment.
It also uses the 256-bit curve secp256k1 used by Bitcoin.
README.md
Outdated
| the OpenSSL tool (`openssl ecparam -list_curves`), are: `prime192v1`, | ||
| `secp224r1`, `prime256v1`, `secp384r1`, and `secp521r1`. It also includes the | ||
| 256-bit curve used by Bitcoin, whose short name is `secp256k1`. No other curves | ||
| are included, but it would not be too hard to add support for more curves |
README.md
Outdated
| a keypair or signing a message. Note: just loading the private key will cause | ||
| keypair generation. Other operations or attack vectors may also be | ||
| vulnerable to attacks. **For a sophisticated attacker observing just one | ||
| operation with private key will be sufficient to completely |
README.md
Outdated
| is to call `s=sk.to_string()`, and then re-create it with | ||
| `SigningKey.from_string(s, curve)` . This short form does not record the | ||
| curve, so you must be sure to tell from_string() the same curve you used for | ||
| curve, so you must be sure to tell `from_string()` the same curve you used for |
make it a bit more modular and make the output look more like OpenSSL's
use calling convention for open that doesn't leak file descriptors emphasise that SHA-1 is the default signature algorithm add examples with compressed and uncompressed formatting
tomato42
force-pushed
the
readme-updates
branch
from
21dd402 to
e5ae843
Compare
Member
Author
I've seen how-to's that used this library on Raspberry PI, on such embedded platforms that is not an unlikely venue of attack... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few things changed since 2008... Update the README and speed.py to make them more current.
fixes #67, fixes #30
Update: