Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renegotiation-disabled: add support for ECDHE #767

Merged
merged 1 commit into from
Aug 9, 2021
Merged

renegotiation-disabled: add support for ECDHE #767

merged 1 commit into from
Aug 9, 2021

Conversation

tomato42
Copy link
Member

@tomato42 tomato42 commented Aug 6, 2021 •
edited
Loading

Description

add support for ECDHE in test-renegotiation-disabled.py script

Motivation and Context

continuation of #563

Checklist

  • I have read the CONTRIBUTING.md document and my PR follows change requirements therein
  • the changes are also reflected in documentation and code comments
  • all new and existing tests pass (see CI results)
  • test script checklist was followed for new scripts
  • new test script added to tlslite-ng.json and tlslite-ng-random-subset.json
  • new and modified scripts were ran against popular TLS implementations:
    • OpenSSL
    • NSS
    • GnuTLS
  • required version of tlslite-ng updated in requirements.txt and README.md

This change is Reviewable

@tomato42 tomato42 added bug unintented behaviour in tlsfuzzer code new test script will require creation of a new connection script labels Aug 6, 2021
@tomato42 tomato42 self-assigned this Aug 6, 2021
@tomato42 tomato42 requested a review from ueno August 9, 2021 14:46
ueno
ueno approved these changes Aug 9, 2021
View reviewed changes
Copy link
Collaborator

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tomato42
Copy link
Member Author

tomato42 commented Aug 9, 2021

Thanks for the review

@tomato42 tomato42 merged commit f2ed926 into master Aug 9, 2021
@tomato42 tomato42 deleted the renego-disabled-ecdhe branch August 9, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueno ueno ueno approved these changes

Assignees

@tomato42 tomato42

Labels
bug unintented behaviour in tlsfuzzer code new test script will require creation of a new connection script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomato42 @ueno